Skip to content

deprecate and replace with interaction_metadata #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions bot opened this issue Mar 21, 2024 · 5 comments · Fixed by #2409
Closed

deprecate and replace with interaction_metadata #2404

github-actions bot opened this issue Mar 21, 2024 · 5 comments · Fixed by #2409

Comments

@github-actions
Copy link
Contributor

Line: 850

pycord//discord/message.py

Lines 847 to 857 in 6fbb08e

self.interaction = MessageInteraction(data=data["interaction"], state=state)
except KeyError:
self.interaction = None
# TODO: deprecate and replace with interaction_metadata
self.thread: Thread | None
try:
self.thread = Thread(
guild=self.guild, state=self._state, data=data["thread"]
)
except KeyError:

@plun1331
Copy link
Member

why does this exist again

@JustaSqu1d
Copy link
Member

why does this exist again

So we don't forget

@plun1331
Copy link
Member

plun1331 commented Mar 21, 2024

why does this exist again

So we don't forget

any sane person (especially 2) looking through changes in a pr will notice a todo comment

@JustaSqu1d
Copy link
Member

JustaSqu1d commented Mar 21, 2024

why does this exist again

So we don't forget

any sane person looking through changes in a pr will notice a todo comment

depends on the todo. some are like do within this PR, some are like do this at a later date. ¯\_(ツ)_/¯

@plun1331 plun1331 linked a pull request Mar 23, 2024 that will close this issue
9 tasks
Copy link
Contributor Author

Closed in commit b97ee6d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants