Skip to content

Include retry-after info on 429 errors #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0xmichalis opened this issue May 4, 2025 · 2 comments · May be fixed by #1671
Open

Include retry-after info on 429 errors #1668

0xmichalis opened this issue May 4, 2025 · 2 comments · May be fixed by #1671
Labels
dev-feature-request features devs want to see

Comments

@0xmichalis
Copy link

0xmichalis commented May 4, 2025 •
edited
Loading

Component

SDK

Describe the feature you would like

It does not look like the SDK returns the retry-after header that is returned by the API on 429 errors so SDK users have no way to use a backoff mechanism and implement retries when ratelimited. Ideally the value of the retry-after header is included in the response body when the SDK throws the 429 error to enable this sort of capability for SDK users.
@0xmichalis 0xmichalis added the dev-feature-request features devs want to see label May 4, 2025
@ryanio
Copy link
Collaborator

ryanio commented May 6, 2025 •
edited
Loading

this is a great idea, i'm not sure if we have time to implement right now but would be open to a PR!

@0xmichalis 0xmichalis linked a pull request May 6, 2025 that will close this issue
Open
@0xmichalis
Copy link
Author

Thanks for the prompt response @ryanio, opened #1671

0xmichalis added a commit to 0xmichalis/opensea-js that referenced this issue May 6, 2025
@0xmichalis
Return typed ratelimit error including retry-after header
e3276c2 
Fixes ProjectOpenSea#1668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-feature-request features devs want to see
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return typed ratelimit error including retry-after header 0xmichalis/opensea-js
2 participants
@ryanio @0xmichalis