test assertion refactor

Author: pauldambra

posthog/api/test/test_event_definition.py

@@ -52,19 +52,16 @@ def setUpTestData(cls):
 
     def test_list_event_definitions(self):
         response = self.client.get("/api/projects/@current/event_definitions/")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], len(self.EXPECTED_EVENT_DEFINITIONS))
-        self.assertEqual(len(response.json()["results"]), len(self.EXPECTED_EVENT_DEFINITIONS))
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == len(self.EXPECTED_EVENT_DEFINITIONS)
+        assert len(response.json()["results"]) == len(self.EXPECTED_EVENT_DEFINITIONS)
 
         for item in self.EXPECTED_EVENT_DEFINITIONS:
             response_item: dict[str, Any] = next(
                 (_i for _i in response.json()["results"] if _i["name"] == item["name"]),
                 {},
             )
-            self.assertAlmostEqual(
-                (dateutil.parser.isoparse(response_item["created_at"]) - timezone.now()).total_seconds(),
-                0,
-            )
+            assert abs((dateutil.parser.isoparse(response_item["created_at"]) - timezone.now()).total_seconds()) < 1
 
     @parameterized.expand(
         [
@@ -116,15 +113,15 @@ def test_list_event_definitions(self):
     )
     def test_list_event_definitions_ordering(self, query_params, expected_results):
         response = self.client.get(f"/api/projects/@current/event_definitions/?{query_params}")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        assert response.status_code == status.HTTP_200_OK
         assert [(r["name"], r["last_seen_at"]) for r in response.json()["results"]] == expected_results
 
     @patch("posthoganalytics.capture")
     def test_delete_event_definition(self, mock_capture):
         event_definition: EventDefinition = EventDefinition.objects.create(team=self.demo_team, name="test_event")
         response = self.client.delete(f"/api/projects/@current/event_definitions/{event_definition.id}/")
-        self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)
-        self.assertEqual(EventDefinition.objects.filter(id=event_definition.id).count(), 0)
+        assert response.status_code == status.HTTP_204_NO_CONTENT
+        assert EventDefinition.objects.filter(id=event_definition.id).count() == 0
         mock_capture.assert_called_once_with(
             self.user.distinct_id,
             "event definition deleted",
@@ -149,11 +146,11 @@ def test_pagination_of_event_definitions(self):
         )
 
         response = self.client.get("/api/projects/@current/event_definitions/")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 306)
-        self.assertEqual(len(response.json()["results"]), 100)  # Default page size
-        self.assertEqual(response.json()["results"][0]["name"], "$pageview")
-        self.assertEqual(response.json()["results"][1]["name"], "entered_free_trial")
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 306
+        assert len(response.json()["results"]) == 100  # Default page size
+        assert response.json()["results"][0]["name"] == "$pageview"
+        assert response.json()["results"][1]["name"] == "entered_free_trial"
 
         event_checkpoints = [
             184,
@@ -164,13 +161,11 @@ def test_pagination_of_event_definitions(self):
 
         for i in range(0, 3):
             response = self.client.get(response.json()["next"])
-            self.assertEqual(response.status_code, status.HTTP_200_OK)
+            assert response.status_code == status.HTTP_200_OK
 
-            self.assertEqual(response.json()["count"], 306)
-            self.assertEqual(
-                len(response.json()["results"]), 100 if i < 2 else 6
-            )  # Each page has 100 except the last one
-            self.assertEqual(response.json()["results"][0]["name"], f"z_event_{event_checkpoints[i]}")
+            assert response.json()["count"] == 306
+            assert len(response.json()["results"]) == (100 if i < 2 else 6)  # Each page has 100 except the last one
+            assert response.json()["results"][0]["name"] == f"z_event_{event_checkpoints[i]}"
 
     def test_cant_see_event_definitions_for_another_team(self):
         org = Organization.objects.create(name="Separate Org")
@@ -179,65 +174,65 @@ def test_cant_see_event_definitions_for_another_team(self):
         EventDefinition.objects.create(team=team, name="should_be_invisible")
 
         response = self.client.get("/api/projects/@current/event_definitions/")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        assert response.status_code == status.HTTP_200_OK
         for item in response.json()["results"]:
-            self.assertNotIn("should_be_invisible", item["name"])
+            assert "should_be_invisible" not in item["name"]
 
         # Also can't fetch for a team to which the user doesn't have permissions
         response = self.client.get(f"/api/projects/{team.pk}/event_definitions/")
-        self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
-        self.assertEqual(response.json(), self.permission_denied_response("You don't have access to the project."))
+        assert response.status_code == status.HTTP_403_FORBIDDEN
+        assert response.json() == self.permission_denied_response("You don't have access to the project.")
 
     def test_query_event_definitions(self):
         # Regular search
         response = self.client.get("/api/projects/@current/event_definitions/?search=app")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 2)  # rated app, installed app
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 2  # rated app, installed app
 
         # Search should be case insensitive
         response = self.client.get("/api/projects/@current/event_definitions/?search=App")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 2)  # rated app, installed app
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 2  # rated app, installed app
 
         # Fuzzy search 1
         response = self.client.get("/api/projects/@current/event_definitions/?search=free tri")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 1)
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 1
         for item in response.json()["results"]:
-            self.assertIn(item["name"], ["entered_free_trial"])
+            assert item["name"] in ["entered_free_trial"]
 
         # Handles URL encoding properly
         response = self.client.get("/api/projects/@current/event_definitions/?search=free%20tri%20")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 1)
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 1
         for item in response.json()["results"]:
-            self.assertIn(item["name"], ["entered_free_trial"])
+            assert item["name"] in ["entered_free_trial"]
 
         # Fuzzy search 2
         response = self.client.get("/api/projects/@current/event_definitions/?search=ed mov")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 1)
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 1
         for item in response.json()["results"]:
-            self.assertIn(item["name"], ["watched_movie"])
+            assert item["name"] in ["watched_movie"]
 
     def test_event_type_event(self):
         action = Action.objects.create(team=self.demo_team, name="action1_app")
 
         response = self.client.get("/api/projects/@current/event_definitions/?search=app&event_type=event")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 2)
-        self.assertNotEqual(response.json()["results"][0]["name"], action.name)
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 2
+        assert response.json()["results"][0]["name"] != action.name
 
     def test_event_type_event_custom(self):
         response = self.client.get("/api/projects/@current/event_definitions/?event_type=event_custom")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 5)
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 5
 
     def test_event_type_event_posthog(self):
         response = self.client.get("/api/projects/@current/event_definitions/?event_type=event_posthog")
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
-        self.assertEqual(response.json()["count"], 1)
-        self.assertEqual(response.json()["results"][0]["name"], "$pageview")
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json()["count"] == 1
+        assert response.json()["results"][0]["name"] == "$pageview"
 
 
 @dataclasses.dataclass