Fixed link process not finishing

muit · muit · commit 1c9a154c5e45 · 2023-02-25T21:48:33.000+01:00
diff --git a/Libs/Backends/LLVM/Compiler/Src/LLVMBackend/Linker.cpp b/Libs/Backends/LLVM/Compiler/Src/LLVMBackend/Linker.cpp
@@ -70,8 +70,14 @@ namespace rift::compiler::LLVM
 				command.Add(outParam.data());
 
 				Log::Info("Linking '{}' from '{}'", p::ToString(filePath), irModule.objectFile);
-				p::RunProcess(command,
-				    SubprocessOptions::TerminateIfDestroyed | SubprocessOptions::CombinedOutErr);
+				auto process   = p::RunProcess(command,
+				      SubprocessOptions::TerminateIfDestroyed | SubprocessOptions::CombinedOutErr);
+				i32 returnCode = 0;
+				p::WaitProcess(process.TryGet(), &returnCode);
+				if (returnCode != 0)
+				{
+					compiler.AddError("Linking failed");
+				}
 			}
 		}
 	}
diff --git a/Libs/Pipe b/Libs/Pipe
@@ -1 +1 @@
-Subproject commit f79a9b2d1db9483920f29fa1ec002cc2c38c8127
+Subproject commit 81e184d485b45fdd33184ea0d0c55a2df2528cbf

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,14 @@ namespace rift::compiler::LLVM`
`70`	`70`	`command.Add(outParam.data());`
`71`	`71`
`72`	`72`	`Log::Info("Linking '{}' from '{}'", p::ToString(filePath), irModule.objectFile);`
`73`		`- p::RunProcess(command,`
`74`		`- SubprocessOptions::TerminateIfDestroyed \| SubprocessOptions::CombinedOutErr);`
	`73`	`+ auto process = p::RunProcess(command,`
	`74`	`+ SubprocessOptions::TerminateIfDestroyed \| SubprocessOptions::CombinedOutErr);`
	`75`	`+ i32 returnCode = 0;`
	`76`	`+ p::WaitProcess(process.TryGet(), &returnCode);`
	`77`	`+ if (returnCode != 0)`
	`78`	`+ {`
	`79`	`+ compiler.AddError("Linking failed");`
	`80`	`+ }`
`75`	`81`	`}`
`76`	`82`	`}`
`77`	`83`	`}`