Skip to content

fix(typescript-fetch): Use null as a value when the date value is nullable #21133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

fix(typescript-fetch): Use null as a value when the date value is nullable #21133

merged 3 commits into from
Apr 28, 2025
+6 −6

Conversation

tikki100
Copy link
Contributor

@tikki100 tikki100 commented Apr 23, 2025 •
edited
Loading

Currently, null is not used as a value for date values - even when the property is nullable. This means you're unable to construct a request with null. This PR fixes that.

PR checklist

  • Read the contribution guidelines.
  • [ x Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./run-in-docker.sh generate -g typescript-fetch -o /gen/samples/client/petstore/typescript-fetch/builds/default-v3.0 -i modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks) (I think I've choosen correctly?)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Technical Committee

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

Related issues

Fix #21132
Fix #11307

Sorry, something went wrong.

@tikki100
fix use null when available for dates

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2
Verified
Learn about vigilant mode
Loading
Loading status checks…
d095ad9
@tikki100 tikki100 force-pushed the typescript-fetch-fix-null-values branch from 84141d1 to d095ad9 Compare April 23, 2025 13:54
@tikki100 tikki100 marked this pull request as ready for review April 23, 2025 14:11
@tikki100
generated typescript-fetch-default-v3.0 sample

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2
Verified
Learn about vigilant mode
Loading
Loading status checks…
f0aef4a
@tikki100 tikki100 force-pushed the typescript-fetch-fix-null-values branch from 95c8aa6 to f0aef4a Compare April 23, 2025 14:13
@macjohnny
Copy link
Member

thanks for the fix!

@macjohnny
Copy link
Member

@tikki100 please update the samples

@tikki100
Copy link
Contributor Author

tikki100 commented Apr 23, 2025 •
edited
Loading

@macjohnny I've re-ran on all typescript-fetch samples :) It changed a package.json for some reason as well, so I've added that as a seperate commit, so it can be git reset head^1 if the CI/CD fails again - idk if it's because I'm using the ./run-in-docker.sh script.

Thanks for the swift response! 👍

@tikki100 tikki100 force-pushed the typescript-fetch-fix-null-values branch from b8e747f to ea66ef7 Compare April 27, 2025 15:32
@tikki100
Copy link
Contributor Author

@macjohnny I saw that it failed with the package.json - funny that it generated that file 🤷 Oh well - I've reverted that commit, so we should be good on the samples now :)

@tikki100
Copy link
Contributor Author

Closed to retrigger circleci tests

@tikki100 tikki100 closed this Apr 28, 2025
@tikki100
Copy link
Contributor Author

tikki100 commented Apr 28, 2025 •
edited
Loading

Reopened to retrigger circleci tests

Edit: Didn't work :(

@macjohnny Would you mind rerunning the circleci tests? :)

Edit: Did a reset and committed again to get the pipeline going - everything should be passing now. Sorry for the confusion :)

@tikki100 tikki100 reopened this Apr 28, 2025
@tikki100
ran all typescript examples

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2
Verified
Learn about vigilant mode
Loading
Loading status checks…
6cd135e
@tikki100 tikki100 force-pushed the typescript-fetch-fix-null-values branch from ea66ef7 to 6cd135e Compare April 28, 2025 08:22
@macjohnny macjohnny merged commit 65c3126 into OpenAPITools:master Apr 28, 2025
15 checks passed
@tikki100 tikki100 deleted the typescript-fetch-fix-null-values branch April 28, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macjohnny macjohnny

Assignees
No one assigned
Labels
Client: TypeScript
Projects
None yet
Milestone
No milestone
2 participants
@tikki100 @macjohnny