Skip to content

Commit 56efbe7

Browse files
committed
Fixed tests and documentation for removed properties.
1 parent 1fc9530 commit 56efbe7

File tree

3 files changed

+3
-62
lines changed

3 files changed

+3
-62
lines changed

docs/api/options.rst

-59
Original file line numberDiff line numberDiff line change
@@ -504,57 +504,6 @@ Options objects
504504
| *Type:* ``bool``
505505
| *Default:* ``False``
506506
507-
.. py:attribute:: soft_rate_limit
508-
509-
.. IMPORTANT::
510-
511-
NOT SUPPORTED ANYMORE -- this option is no longer used
512-
513-
Puts are delayed 0-1 ms when any level has a compaction score that exceeds
514-
soft_rate_limit. This is ignored when == 0.0.
515-
CONSTRAINT: soft_rate_limit <= hard_rate_limit. If this constraint does not
516-
hold, RocksDB will set soft_rate_limit = hard_rate_limit.
517-
A value of ``0`` means disabled.
518-
519-
| *Type:* ``float``
520-
| *Default:* ``0``
521-
522-
.. py:attribute:: hard_rate_limit
523-
524-
.. IMPORTANT::
525-
526-
NOT SUPPORTED ANYMORE -- this option is no longer used
527-
528-
Puts are delayed 1ms at a time when any level has a compaction score that
529-
exceeds hard_rate_limit. This is ignored when <= 1.0.
530-
A value fo ``0`` means disabled.
531-
532-
| *Type:* ``float``
533-
| *Default:* ``0``
534-
535-
.. py:attribute:: rate_limit_delay_max_milliseconds
536-
537-
.. IMPORTANT::
538-
539-
NOT SUPPORTED ANYMORE -- this option is no longer used
540-
541-
Max time a put will be stalled when hard_rate_limit is enforced. If 0, then
542-
there is no limit.
543-
544-
| *Type:* ``int``
545-
| *Default:* ``1000``
546-
547-
.. py:attribute:: purge_redundant_kvs_while_flush
548-
549-
.. IMPORTANT::
550-
551-
NOT SUPPORTED ANYMORE -- this option is no longer used
552-
553-
Purge duplicate/deleted keys when a memtable is flushed to storage.
554-
555-
| *Type:* ``bool``
556-
| *Default:* ``True``
557-
558507
559508
560509
.. py:class:: rocksdb.Options
@@ -819,14 +768,6 @@ Options objects
819768
| *Type:* ``bool``
820769
| *Default:* ``True``
821770
822-
.. py:attribute:: skip_log_error_on_recovery
823-
824-
Skip log corruption error on recovery
825-
(If client is ok with losing most recent changes)
826-
827-
| *Type:* ``bool``
828-
| *Default:* ``False``
829-
830771
.. py:attribute:: stats_dump_period_sec
831772
832773
If not zero, dump rocksdb.stats to LOG every stats_dump_period_sec

rocksdb/options.pxd

-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ cdef extern from "rocksdb/options.h" namespace "rocksdb":
134134
cpp_bool use_direct_io_for_flush_and_compaction
135135
cpp_bool allow_fallocate
136136
cpp_bool is_fd_close_on_exec
137-
cpp_bool skip_log_error_on_recovery
138137
unsigned int stats_dump_period_sec
139138
unsigned int stats_persist_period_sec
140139
cpp_bool persist_stats_to_disk

rocksdb/tests/test_options.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
import unittest
21
import sys
2+
import unittest
3+
34
import rocksdb
45

6+
57
class TestFilterPolicy(rocksdb.interfaces.FilterPolicy):
68
def create_filter(self, keys):
79
return b'nix'
@@ -230,7 +232,6 @@ def test_rocksdb_options(self):
230232
('use_direct_io_for_flush_and_compaction', False, True),
231233
('allow_fallocate', True, False),
232234
('is_fd_close_on_exec', True, False),
233-
('skip_log_error_on_recovery', False, True),
234235
('stats_dump_period_sec', 600, 3600),
235236
('stats_persist_period_sec', 600, 3600),
236237
('persist_stats_to_disk', False, True),

0 commit comments

Comments
 (0)