Skip to content

Commit 93448e1

Browse files
committed
Add credits to RELEASE.md. Resolve ambiguity in top-level test file.
1 parent f0a3105 commit 93448e1

File tree

2 files changed

+22
-18
lines changed

2 files changed

+22
-18
lines changed

RELEASE.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,12 @@
1212
* Test that patch works in Python 3
1313
* Test that package will install when TensorFlow is not yet installed
1414

15+
Developed by Duncan Riach with special thanks to Nathan Luehr for review.
16+
1517
# Release 0.1.0
1618

1719
This release includes a patch for standard TF 1.14.0 that enables most deep
1820
learning TF models to train deterministically on GPUs. GPU-determinism support
1921
in the NVIDIA NGC TF containers is also described.
22+
23+
Developed by Duncan Riach with special thanks to Nathan Luehr for review.

test/all.sh

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -44,32 +44,32 @@ expect () {
4444

4545
version=$(python get_version.py)
4646

47-
PASS=0
48-
FAIL=1
47+
OK=0
48+
ERROR=1
4949

50-
expect $PASS "Successfully installed tensorflow-determinism" \
51-
./install_package.sh
50+
expect $OK "Successfully installed tensorflow-determinism" \
51+
./install_package.sh
5252

53-
expect $FAIL "Exception: tfdeterminism: TensorFlow inside NGC containers does not require patching" \
54-
./container.sh nvcr.io/nvidia/tensorflow:19.09-py2 test_patch_apply.sh
53+
expect $ERROR "Exception: tfdeterminism: TensorFlow inside NGC containers does not require patching" \
54+
./container.sh nvcr.io/nvidia/tensorflow:19.09-py2 test_patch_apply.sh
5555

56-
expect $FAIL "Exception: tfdeterminism: No patch available for version 1.13.1 of TensorFlow" \
57-
./container.sh tensorflow/tensorflow:1.13.1-gpu test_patch_apply.sh
56+
expect $ERROR "Exception: tfdeterminism: No patch available for version 1.13.1 of TensorFlow" \
57+
./container.sh tensorflow/tensorflow:1.13.1-gpu test_patch_apply.sh
5858

59-
expect $PASS "TensorFlow version 1.14.0 has been patched using tfdeterminism version ${version}" \
60-
./container.sh tensorflow/tensorflow:1.14.0-gpu test_patch_apply.sh
59+
expect $OK "TensorFlow version 1.14.0 has been patched using tfdeterminism version ${version}" \
60+
./container.sh tensorflow/tensorflow:1.14.0-gpu test_patch_apply.sh
6161

62-
expect $PASS "" \
63-
./container.sh tensorflow/tensorflow:1.14.0-gpu test_patch.sh
62+
expect $OK "" \
63+
./container.sh tensorflow/tensorflow:1.14.0-gpu test_patch.sh
6464

65-
expect $PASS "" \
66-
./container.sh tensorflow/tensorflow:1.14.0-gpu-py3 test_patch.sh
65+
expect $OK "" \
66+
./container.sh tensorflow/tensorflow:1.14.0-gpu-py3 test_patch.sh
6767

68-
expect $PASS "" \
69-
./container.sh tensorflow/tensorflow:1.15.0rc2-gpu test_patch.sh
68+
expect $OK "" \
69+
./container.sh tensorflow/tensorflow:1.15.0rc2-gpu test_patch.sh
7070

71-
expect $FAIL "Exception: tfdeterminism: No patch available for version 2.0.0 of TensorFlow" \
72-
./container.sh tensorflow/tensorflow:2.0.0-gpu test_patch.sh
71+
expect $ERROR "Exception: tfdeterminism: No patch available for version 2.0.0 of TensorFlow" \
72+
./container.sh tensorflow/tensorflow:2.0.0-gpu test_patch.sh
7373

7474
echo "${PASS_COUNT} tests passed"
7575
echo "${FAIL_COUNT} tests failed"

0 commit comments

Comments
 (0)