Skip to content

Commit f9b8336

Browse files
committed
Updating the biochemistry pages to use reversibility instead of direction
1 parent fd3cf03 commit f9b8336

File tree

4 files changed

+14
-17
lines changed

4 files changed

+14
-17
lines changed

README.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,16 @@
33

44
## Requirements
55
- node (https://nodejs.org/)
6-
- bower `npm install -g bower`
7-
8-
6+
(it is recommended that you use nvm to manage versions of node and the package manager npm)
97

108
## Local Installation
119

1210
```
1311
git clone --recursive https://github.com/modelseed/modelseed-ui.git modelseed-ui
1412
cd modelseed-ui
15-
bower install
13+
npm install
1614
```
1715

18-
Notes:
19-
- `bower install` installs some third-party (front-end) dependencies
20-
21-
2216
Now point your favorite webserver at `modelseed-ui` and you are ready to go!
2317

2418
From `modelseed-ui`:

app/ctrls/ms-ctrls.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ function($s, Biochem, $state, $stateParams, MS, Session) {
258258
var rxn_sFields = ['id', 'name', 'status', 'synonyms', 'aliases', 'pathways', 'stoichiometry', 'notes'];
259259
$s.rxnOpts = Session.getOpts($state, 'rxns') ||
260260
{query: '', limit: 25, offset: 0, sort: {field: 'id'}, core: 'reactions', searchFields: rxn_sFields,
261-
visible: ['name', 'id', 'definition', 'deltag', 'deltagerr', 'direction', 'stoichiometry', 'status',
261+
visible: ['name', 'id', 'definition', 'deltag', 'deltagerr', 'reversibility', 'stoichiometry', 'status',
262262
'aliases', 'is_obsolete', 'is_transport', 'ontology', 'pathways', 'notes', 'is_transport'] };
263263

264264
// Compounds
@@ -279,7 +279,7 @@ function($s, Biochem, $state, $stateParams, MS, Session) {
279279
{label: 'Equation', key: 'stoichiometry', format: function(r) {
280280
if (!r.stoichiometry) return "N/A";
281281
var stoich = r.stoichiometry.replace(/\"/g, '')
282-
return '<span style="white-space: wrap"'+'stoichiometry-to-eq="'+stoich+'" direction="'+r.direction+'"></span>';
282+
return '<span style="white-space: wrap"'+'stoichiometry-to-eq="'+stoich+'" direction="'+r.reversibility+'"></span>';
283283
}},
284284
{label: 'Transport', key: 'is_transport', format: function(row){
285285
return row.is_transport? 'Yes' : 'No';
@@ -439,7 +439,7 @@ function($s, Biochem, $state, $stateParams, Session) {
439439
// cpd_Reactions
440440
var cpd_rxn_sFields = ['id', 'name', 'status', 'aliases', 'pathways', 'ontology', 'stoichiometry', 'notes'];
441441
$s.cpd_rxnOpts = {query: $s.id, limit: 25, offset: 0, sort: {field: 'id'}, core: 'reactions', searchFields: cpd_rxn_sFields,
442-
visible: ['name', 'id', 'definition', 'deltag', 'deltagerr', 'direction', 'stoichiometry', 'status',
442+
visible: ['name', 'id', 'definition', 'deltag', 'deltagerr','reversibility', 'stoichiometry', 'status',
443443
'inchikey', 'smiles', 'aliases', 'is_obsolete', 'ontology', 'pathways', 'notes', 'is_transport'] };
444444

445445
$s.cpd_rxnHeader = [
@@ -453,7 +453,7 @@ function($s, Biochem, $state, $stateParams, Session) {
453453
{label: 'Equation', key: 'stoichiometry', format: function(r) {
454454
if (!r.stoichiometry) return "N/A";
455455
var stoich = r.stoichiometry.replace(/\"/g, '')
456-
return '<span style="white-space: wrap;"'+'stoichiometry-to-eq="'+stoich+'" direction="'+r.direction+'"></span>';
456+
return '<span style="white-space: wrap;"'+'stoichiometry-to-eq="'+stoich+'" direction="'+r.reversibility+'"></span>';
457457
}},
458458
{label: 'Transport', key: 'is_transport', format: function(row){
459459
return row.is_transport? 'Yes' : 'No';

app/directives/directives.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2190,6 +2190,8 @@ function(Dialogs, $dialog) {
21902190

21912191
if (dir === '=')
21922192
var dirClass = 'fa-arrows-h';
2193+
else if (dir == '?')
2194+
var dirClass = 'fa-arrows-h';
21932195
else if (dir === '>')
21942196
var dirClass = 'fa-long-arrow-right';
21952197
else if (dir === '<')
@@ -2243,8 +2245,13 @@ function(Dialogs, $dialog) {
22432245
var parts = stoichString.split(';');
22442246
var dir = scope.direction;
22452247

2248+
console.log("Testing")
2249+
console.log(dir)
2250+
22462251
if (dir === '=')
22472252
var dirClass = 'fa-arrows-h';
2253+
else if (dir == '?')
2254+
var dirClass = 'fa-arrows-h';
22482255
else if (dir === '>')
22492256
var dirClass = 'fa-long-arrow-right';
22502257
else if (dir === '<')

app/views/biochem/reaction.html

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<div layout="row" ng-if="!loading">
6262
<div flex="20" layout="column"><strong>Equation</strong></div>
6363
<div flex="80" layout="column">
64-
<span stoichiometry-to-imgs="{{rxn.stoichiometry}}" direction="{{rxn.direction}}"></span>
64+
<span stoichiometry-to-imgs="{{rxn.stoichiometry}}" direction="{{rxn.reversibility}}"></span>
6565
</div>
6666
</div>
6767
<hr>
@@ -87,10 +87,6 @@
8787
<div flex="20" layout="column"><strong>EC numbers</strong></div>
8888
<div flex="80" layout="column">{{rxn.ec_numbers_display}}</div>
8989
</div>
90-
<div layout="row">
91-
<div flex="20" layout="column"><strong>Direction</strong></div>
92-
<div flex="80" layout="column">{{rxn.direction}}</div>
93-
</div>
9490
<div layout="row">
9591
<div flex="20" layout="column"><strong>Thermodynamic reversibility</strong></div>
9692
<div flex="80" layout="column">{{rxn.reversibility}}</div>

0 commit comments

Comments
 (0)