Replies: 1 comment 2 replies
-
yea, I definitely want to go through and update the schema's to make them a bit more friendly. My first pass was just to make it all worked. As a starting point, I agree that we should change:
|
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
For the most part it looks like the schema follows the field naming of Comic Vine (which makes sense), but it might make the package easier to use if it was a bit less verbose. For example in the
IssueSchema
, one of the fields ischaracter_credits
where it would probably be better to shorten it tocharacters
. So in use it would be:instead of
Just in the
IssueSchema
I'm thinking it might make sense to rename all the_credits
fields and also rename some other fields likeissue_number
(drop the redundant prefix), possibly changingperson_credits
tocreators
, etc.Anyway, before working on this further I wanted to get some feedback to see if it's worthwhile to pursue.
Beta Was this translation helpful? Give feedback.
All reactions