Skip to content

Commit 81ab4a4

Browse files
authored
Update to hickory-dns 0.25.1 (#42)
* Update to hickory-dns 0.25.1 * Adjustments for PR feedback * Switched the default crypto provider to aws-lc-rs instead of ring * Change debug to warn on multiple questions in one dns query * Made it so aws-lc-rs & ring are not mutually exclusive * When aws-lc-rs & ring are both enabled, use ring to match hickory Based on hickory's source code (see link below), hickory will currently use ring if both aws-lc-rs & ring are enabled at the same time. In order to match that behavior, I've swapped the default. * https://github.com/hickory-dns/hickory-dns/blob/0f44977800ca8954e86723fcc391514008d2bb1d/crates/proto/src/rustls/mod.rs#L50 * Utilize cargo-hack in CI for testing feature combinations The aws-lc-rs feature, ring feature, or both features must be enabled in order for the project to compile. cargo-hack's --at-least-one-of flag allows for representing this requirement while still allowing the CI to test every possible feature combination.
1 parent 8479809 commit 81ab4a4

File tree

6 files changed

+1310
-255
lines changed

6 files changed

+1310
-255
lines changed

.github/workflows/rust.yml

+3-5
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,16 @@ jobs:
1414
- run: sudo apt-get update -y && sudo apt-get install -y knot-dnsutils
1515
- uses: dtolnay/rust-toolchain@stable
1616
id: "rust-toolchain"
17-
- name: install cargo-all-features
18-
uses: baptiste0928/cargo-install@v2
19-
with:
20-
crate: cargo-all-features
17+
- name: install cargo-hack
18+
uses: taiki-e/install-action@cargo-hack
2119
- uses: actions/cache@v3
2220
with:
2321
path: |
2422
~/.cargo/git
2523
~/.cargo/registry
2624
target
2725
key: "${{runner.os}} Rust ${{steps.rust-toolchain.outputs.cachekey}} Lock ${{hashFiles('Cargo.lock')}}"
28-
- run: cargo test-all-features --locked -- --include-ignored
26+
- run: cargo hack test --feature-powerset --at-least-one-of aws-lc-rs,ring --locked -- --include-ignored
2927
env:
3028
RUST_BACKTRACE: 1
3129

0 commit comments

Comments
 (0)