Update packages, fix test code style and remove unused test code.

Author: GGG-KILLER

.github/workflows/build-and-test.yml

@@ -42,4 +42,14 @@ jobs:
       - name: Build
         run: dotnet build --no-restore
       - name: Run Tests
-        run: dotnet test --no-build -- xunit.parallelizeAssembly=true xunit.parallelizeTestCollections=true xunit.maxParallelThreads=-1
+        run: |
+          dotnet test \
+            --no-build \
+            -- \
+            --xunit-info --output Detailed \
+            xUnit.DiagnosticMessages=true \
+            xUnit.Explicit=on \
+            xUnit.MaxParallelThreads=unlimited \
+            xUnit.ParallelAlgorithm=aggressive \
+            xUnit.ParallelizeAssembly=true \
+            xUnit.ParallelizeTestCollections=true

Loretta.sln.DotSettings

@@ -1,8 +1,9 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=CheckNamespace/@EntryIndexedValue">DO_NOT_SHOW</s:String>
-    <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=RemoveRedundantBraces/@EntryIndexedValue">SUGGESTION</s:String>
+    <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=RemoveRedundantBraces/@EntryIndexedValue">DO_NOT_SHOW</s:String>
     <s:Boolean x:Key="/Default/UserDictionary/Words/=elseif_0027s/@EntryIndexedValue">True</s:Boolean>
     <s:Boolean x:Key="/Default/UserDictionary/Words/=exponentiate/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=lexes/@EntryIndexedValue">True</s:Boolean>
     <s:Boolean x:Key="/Default/UserDictionary/Words/=lua_0027s/@EntryIndexedValue">True</s:Boolean>
     <s:Boolean x:Key="/Default/UserDictionary/Words/=nilable/@EntryIndexedValue">True</s:Boolean>
     <s:Boolean x:Key="/Default/UserDictionary/Words/=reparsed/@EntryIndexedValue">True</s:Boolean>

build/LibraryProject.props

@@ -4,7 +4,6 @@
 
     <PropertyGroup>
         <TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
-        <TargetFrameworks Condition="'$(IsUnusedAnalysis)' == 'true'">net8.0</TargetFrameworks>
         <OutputType>Library</OutputType>
         <NeutralLanguage>en-US</NeutralLanguage>
     </PropertyGroup>
@@ -45,7 +44,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
+        <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

src/Compilers/Core/Portable/Loretta.CodeAnalysis.csproj

@@ -20,12 +20,12 @@
 
     <!-- Packages that we need from .NET 6+ on .NET Standard 2.0 -->
     <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
-        <PackageReference Include="System.Collections.Immutable" Version="6.0.0" />
-        <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
-        <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
-        <PackageReference Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
-        <PackageReference Include="System.Text.Encoding.CodePages" Version="6.0.0" />
-        <PackageReference Include="System.Memory" Version="4.5.5" />
+        <PackageReference Include="Microsoft.Bcl.HashCode" Version="6.0.0" />
+        <PackageReference Include="System.Collections.Immutable" Version="9.0.3" />
+        <PackageReference Include="System.Memory" Version="4.6.2" />
+        <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="6.1.1" />
+        <PackageReference Include="System.Text.Encoding.CodePages" Version="9.0.3" />
+        <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.6.2" />
     </ItemGroup>
 
     <ItemGroup>

src/Compilers/Core/Test/Utilities/Assert/AssertEx.cs

@@ -13,49 +13,50 @@ namespace Loretta.Test.Utilities
     /// </summary>
     public static class AssertEx
     {
-        public static void Equal(bool[,] expected, Func<int, int, bool> getResult, int size) =>
-            Equal<bool>(expected, getResult, (b1, b2) => b1 == b2, b => b ? "true" : "false", "{0,-6:G}", size);
+        public static void Equal(bool[,] expected, Func<int, int, bool> getResult, int size)
+            => Equal(
+                expected,
+                getResult,
+                static (b1, b2) => b1 == b2,
+                static b => b ? "true" : "false",
+                "{0,-6:G}",
+                size);
 
-        public static void Equal<T>(T[,] expected, Func<int, int, T> getResult, Func<T, T, bool> valuesEqual, Func<T, string> printValue, string format, int size)
+        public static void Equal<T>(
+            T[,]              expected,
+            Func<int, int, T> getResult,
+            Func<T, T, bool>  valuesEqual,
+            Func<T, string>   printValue,
+            string            format,
+            int               size)
         {
-            bool mismatch = false;
-            for (int i = 0; i < size; i++)
+            var mismatch = false;
+            for (var i = 0; i < size; i++)
             {
-                for (int j = 0; j < size; j++)
+                for (var j = 0; j < size; j++)
                 {
-                    if (!valuesEqual(expected[i, j], getResult(i, j)))
-                    {
-                        mismatch = true;
-                    }
+                    if (!valuesEqual(expected[i, j], getResult(i, j))) mismatch = true;
                 }
             }
 
-            if (mismatch)
+            if (!mismatch) return;
+            var builder = new StringBuilder();
+            builder.AppendLine("Actual result: ");
+            for (var i = 0; i < size; i++)
             {
-                var builder = new StringBuilder();
-                builder.AppendLine("Actual result: ");
-                for (int i = 0; i < size; i++)
+                builder.Append("{ ");
+                for (var j = 0; j < size; j++)
                 {
-                    builder.Append("{ ");
-                    for (int j = 0; j < size; j++)
-                    {
-                        string resultWithComma = printValue(getResult(i, j));
-                        if (j < size - 1)
-                        {
-                            resultWithComma += ",";
-                        }
+                    var resultWithComma               = printValue(getResult(i, j));
+                    if (j < size - 1) resultWithComma += ",";
 
-                        builder.Append(string.Format(format, resultWithComma));
-                        if (j < size - 1)
-                        {
-                            builder.Append(' ');
-                        }
-                    }
-                    builder.AppendLine("},");
+                    builder.Append(string.Format(format, resultWithComma));
+                    if (j < size - 1) builder.Append(' ');
                 }
-
-                Assert.True(false, builder.ToString());
+                builder.AppendLine("},");
             }
+
+            Assert.Fail(builder.ToString());
         }
     }
 }

src/Compilers/Core/Test/Utilities/Assert/ConditionalFactAttribute.cs

@@ -40,7 +40,7 @@ public ConditionalTheoryAttribute(params Type[] skipConditions)
             foreach (var skipCondition in skipConditions)
             {
                 var condition = (ExecutionCondition) Activator.CreateInstance(skipCondition);
-                if (condition.ShouldSkip)
+                if (condition!.ShouldSkip)
                 {
                     base.Skip = Reason ?? condition.SkipReason;
                     break;
@@ -52,44 +52,63 @@ public ConditionalTheoryAttribute(params Type[] skipConditions)
     public abstract class ExecutionCondition
     {
         public abstract bool ShouldSkip { get; }
+
         public abstract string SkipReason { get; }
     }
 
     public static class ExecutionConditionUtil
     {
-        public static ExecutionArchitecture Architecture => IntPtr.Size switch
-        {
-            4 => ExecutionArchitecture.x86,
-            8 => ExecutionArchitecture.x64,
-            _ => throw new InvalidOperationException($"Unrecognized pointer size {IntPtr.Size}")
-        };
-        public static ExecutionConfiguration Configuration =>
+        // ReSharper disable once BuiltInTypeReferenceStyleForMemberAccess
+        public static ExecutionArchitecture Architecture
+            => IntPtr.Size switch
+            {
+                4 => ExecutionArchitecture.X86,
+                8 => ExecutionArchitecture.X64,
+                // ReSharper disable once BuiltInTypeReferenceStyleForMemberAccess
+                _ => throw new InvalidOperationException($"Unrecognized pointer size {IntPtr.Size}"),
+            };
+
+        public static ExecutionConfiguration Configuration
+            =>
 #if DEBUG
-            ExecutionConfiguration.Debug;
+                ExecutionConfiguration.Debug;
 #elif RELEASE
             ExecutionConfiguration.Release;
 #else
 #error Unsupported Configuration
 #endif
 
         public static bool IsWindows => Path.DirectorySeparatorChar == '\\';
+
         public static bool IsUnix => !IsWindows;
-        public static bool IsMacOS => RuntimeInformation.IsOSPlatform(OSPlatform.OSX);
+
+        public static bool IsMacOs => RuntimeInformation.IsOSPlatform(OSPlatform.OSX);
+
         public static bool IsLinux => RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
+
         public static bool IsDesktop => RuntimeUtilities.IsDesktopRuntime;
+
         public static bool IsWindowsDesktop => IsWindows && IsDesktop;
+
         public static bool IsMonoDesktop => Type.GetType("Mono.Runtime") != null;
+
         public static bool IsMono => MonoHelpers.IsRunningOnMono();
+
         public static bool IsCoreClr => !IsDesktop;
+
         public static bool IsCoreClrUnix => IsCoreClr && IsUnix;
+
         public static bool IsMonoOrCoreClr => IsMono || IsCoreClr;
-        public static bool RuntimeSupportsCovariantReturnsOfClasses => Type.GetType("System.Runtime.CompilerServices.RuntimeFeature")?.GetField("CovariantReturnsOfClasses") != null;
+
+        public static bool RuntimeSupportsCovariantReturnsOfClasses
+            => Type.GetType("System.Runtime.CompilerServices.RuntimeFeature")?.GetField("CovariantReturnsOfClasses")
+               != null;
     }
 
     public enum ExecutionArchitecture
     {
-        x86,
-        x64,
+        X86,
+        X64,
     }
 
     public enum ExecutionConfiguration