Skip to content

Remove optional section relating to GitHub Pages Theme Chooser #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex-ball opened this issue May 21, 2025 · 0 comments
Open

Remove optional section relating to GitHub Pages Theme Chooser #180

alex-ball opened this issue May 21, 2025 · 0 comments
Labels
type:clarification Suggest change for make lesson clearer

Comments

@alex-ball
Copy link
Contributor

alex-ball commented May 21, 2025

How could the content be improved?

The GitHub Pages episode takes the learner through the settings screen where they can configure certain aspects of their Pages workflow.

This used to have two widgets, "Source" and "Theme Chooser", so the episode broke the task down into three steps: find the page, "Source branch (required)" and "Theme (optional)".

The settings have changed to make it easier to use build systems other than Jekyll, however:

  • Source: Deploy from a branch (default, same as previous) or GitHub Actions (new)
  • Branch: Same as previous "source"
  • Custom domain, enforce HTTPS (shown after branch is selected)
  • Visibility: (paid feature)

The Jekyll-specific Theme Chooser has been removed. Instead there is a link to documentation explaining how to set the theme in a _config.yml file, which is not something we touch on. The link we provide to documentation on the Theme Chooser now redirects to that same page:

See the [GitHub Pages documentation](https://docs.github.com/en/pages/getting-started-with-github-pages/adding-a-theme-to-your-github-pages-site-with-the-theme-chooser) for further information on using themes.

Given that the scope of that passage is really to guide learners through the settings page rather than theme the Pages site, I think it would be best if we remove the "Theme (optional)" section.

Which part of the content does your suggestion apply to?

https://librarycarpentry.github.io/lc-git/05-github-pages.html#theme-optional

@alex-ball alex-ball added the type:clarification Suggest change for make lesson clearer label May 21, 2025
@alex-ball alex-ball changed the title Remove optional section relating to GitHub Theme Chooser Remove optional section relating to GitHub Pages Theme Chooser May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:clarification Suggest change for make lesson clearer
Projects
None yet
Development

No branches or pull requests

1 participant