Skip to content

Commit 8e91dfa

Browse files
wesbiggsWes Biggs
and
Wes Biggs
authored
Fix usage of parquet appendRow method, which should be called async (#4)
See discussion at LibertyDSNP/parquetjs#157 Co-authored-by: Wes Biggs <[email protected]>
1 parent 53f95c8 commit 8e91dfa

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ import { ParquetWriter, ParquetSchema } from "@dsnp/parquetjs";
5656

5757
const [parquetSchema, writerOptions] = parquet.fromDSNPSchema(descriptorForAnnouncementType(AnnouncementType.Broadcast).parquetSchema);
5858
const writer = await ParquetWriter.openFile(new ParquetSchema(parquetSchema), "./file.parquet", writerOptions);
59-
writer.appendRow({
59+
await writer.appendRow({
6060
announcementType: AnnouncementType.Broadcast,
6161
contentHash: "bciqdnu347gcfmxzbkhgoubiobphm6readngitfywktdtbdocgogop2q",
6262
fromId: 78187493520,

parquet.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe("DSNP Schema Conversion Test File", () => {
2121

2222
beforeAll(async () => {
2323
const writer = await ParquetWriter.openFile(new ParquetSchema(parquetSchema), path, writerOptions);
24-
writer.appendRow(row1);
24+
await writer.appendRow(row1);
2525
await writer.close();
2626

2727
reader = await ParquetReader.openFile(path);

0 commit comments

Comments
 (0)