Skip to content

Stack overflow in grid layout with max-height: max-content #4261

Open
@tcl3

Description

@tcl3

Found with Domato

Reduction

<!DOCTYPE html>
<style>
    div { display: grid; min-height: max-content; }
</style>
<div></div>

Stack trace:

#0  0x00007902f87328bb in append () at /home/tim/repos/ladybird/AK/Vector.h:278
#1  track_list () at /home/tim/repos/ladybird/Libraries/LibWeb/CSS/GridTrackSize.cpp:269
#2  0x00007902f8bc168b in initialize_grid_tracks_for_columns_and_rows ()
    at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/GridFormattingContext.cpp:594
#3  0x00007902f8bcc466 in run () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/GridFormattingContext.cpp:1980
#4  0x00007902f8bb9629 in calculate_max_content_height () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/FormattingContext.cpp:1569
#5  0x00007902f8bb7033 in calculate_inner_height () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/FormattingContext.cpp:1617
#6  0x00007902f8bcc6ca in run () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/GridFormattingContext.cpp:2037
#7  0x00007902f8bb9629 in calculate_max_content_height () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/FormattingContext.cpp:1569
#8  0x00007902f8bb7033 in calculate_inner_height () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/FormattingContext.cpp:1617
#9  0x00007902f8bcc6ca in run () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/GridFormattingContext.cpp:2037
#10 0x00007902f8bb9629 in calculate_max_content_height () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/FormattingContext.cpp:1569
#11 0x00007902f8bb7033 in calculate_inner_height () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/FormattingContext.cpp:1617
#12 0x00007902f8bcc6ca in run () at /home/tim/repos/ladybird/Libraries/LibWeb/Layout/GridFormattingContext.cpp:2037
<~23000 stack frames omitted>

This WPT seems to crash because of the same issue: https://wpt.live/css/css-grid/layout-algorithm/flex-sizing-rows-min-max-height-001.html

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcss gridhas reproWe have a way to reproduce this bug.layout

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions