Skip to content

Commit 1fc09ad

Browse files
committed
tweaks and warning message
Signed-off-by: darrell-k <[email protected]>
1 parent 0d04d3e commit 1fc09ad

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

Slim/Formats.pm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ sub sanitizeTagValues {
292292
my $original = $value;
293293

294294
use bytes;
295-
if ( my $cached = $tagCache{$value} ) {
295+
if ( my $cached = $tagCache{$tag}{$value} ) {
296296
$tags->{$tag} = $cached;
297297
next;
298298

@@ -335,7 +335,7 @@ sub sanitizeTagValues {
335335
$value = $tags->{$tag} = \@mbIDs;
336336
}
337337

338-
$tagCache{$original} = $value;
338+
$tagCache{$tag}{$original} = $value;
339339
}
340340

341341
main::DEBUGLOG && $log->is_debug && $value && $log->debug(". $tag : $value");

Slim/Formats/FLAC.pm

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -221,17 +221,13 @@ sub _getStandardTag {
221221
my $tags = $s->{tags} || {};
222222

223223
$class->_addInfoTags($s, $tags);
224-
$class->_doTagMapping($tags);
224+
$class->doTagMapping($tags);
225225
$class->_addArtworkTags($s, $tags);
226226

227227
return $tags;
228228
}
229229

230230
sub doTagMapping {
231-
return _doTagMapping(@_);
232-
}
233-
234-
sub _doTagMapping {
235231
my ($class, $tags) = @_;
236232

237233
# Map ID3 tags first, so FLAC tags win out
@@ -536,7 +532,7 @@ sub _getXMLTags {
536532

537533
%{$tracks->{$cuesheetTrack}} = (%{$defaultTags}, %{$tracks->{$cuesheetTrack}});
538534

539-
$class->_doTagMapping($tracks->{$cuesheetTrack});
535+
$class->doTagMapping($tracks->{$cuesheetTrack});
540536
}
541537
}
542538

@@ -631,7 +627,7 @@ sub _getNumberedVCs {
631627

632628
%{$tracks->{$num}} = (%{$defaultTags}, %{$tracks->{$num}});
633629

634-
$class->_doTagMapping($tracks->{$num});
630+
$class->doTagMapping($tracks->{$num});
635631

636632
$tracks->{$num}->{TRACKNUM} = $num unless exists $tracks->{$num}->{TRACKNUM};
637633
}
@@ -730,7 +726,7 @@ sub _getCDDBTags {
730726

731727
%{$tracks->{$key}} = (%{$tags}, %{$tracks->{$key}});
732728

733-
$class->_doTagMapping($tracks->{$key});
729+
$class->doTagMapping($tracks->{$key});
734730
}
735731

736732
return $items;
@@ -787,7 +783,7 @@ sub _getCUEinVCs {
787783
}
788784
}
789785

790-
$class->_doTagMapping($tracks->{$key});
786+
$class->doTagMapping($tracks->{$key});
791787

792788
$items++;
793789
}

Slim/Schema.pm

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2644,6 +2644,9 @@ sub _preCheckAttributes {
26442644

26452645
# Normalize attribute names
26462646
while ( my ($key, $val) = each %{ $args->{'attributes'} } ) {
2647+
if ( $key =~ /^MUSICBRAINZ.*ID$/ && $val && ref $val ne 'ARRAY' ) {
2648+
logWarning("$key ($val) in " . Slim::Utils::Misc::pathFromFileURL($url) . " has not been validated by Slim::Formats::sanitizeTagValues");
2649+
}
26472650
# don't overwrite mapped values
26482651
next if $mappedValues{$key};
26492652

0 commit comments

Comments
 (0)