Improve prefs UI

Author: marcocipriani01

app/src/main/java/org/indilib/i4j/iparcos/PrefsFragment.java

@@ -57,9 +57,11 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
                     prefScreen.addPreference(prefGroup);
                     for (INDIProperty<?> prop : props) {
                         PropPref<?> pref = PropPref.create(context, prop);
-                        if (pref != null) pref.setIconSpaceReserved(false);
-                        map.put(prop, pref);
-                        prefGroup.addPreference(pref);
+                        if (pref != null) {
+                            pref.setIconSpaceReserved(false);
+                            map.put(prop, pref);
+                            prefGroup.addPreference(pref);
+                        }
                     }
                 }
             }
@@ -91,13 +93,17 @@ public void newProperty(INDIDevice device, final INDIProperty<?> property) {
             PreferenceCategory prefGroup = groups.get(group);
             if (prefGroup == null) {
                 prefGroup = new PreferenceCategory(context);
+                prefGroup.setIconSpaceReserved(false);
                 groups.put(group, prefGroup);
                 prefGroup.setTitle(group);
                 prefScreen.addPreference(prefGroup);
             }
             PropPref<?> pref = PropPref.create(context, property);
-            map.put(property, pref);
-            prefGroup.addPreference(pref);
+            if (pref != null) {
+                pref.setIconSpaceReserved(false);
+                map.put(property, pref);
+                prefGroup.addPreference(pref);
+            }
         });
     }
 

app/src/main/java/org/indilib/i4j/iparcos/prop/NumberPropPref.java

@@ -58,7 +58,6 @@ protected Spannable createSummary() {
             }
             stringBuilder.append(elements.get(i).getValueAsString());
             return new SpannableString(stringBuilder.toString());
-
         } else {
             return new SpannableString(getContext().getString(R.string.no_indi_elements));
         }

app/src/main/java/org/indilib/i4j/iparcos/prop/PropPref.java

@@ -31,9 +31,7 @@ public abstract class PropPref<Element extends INDIElement> extends Preference i
     protected PropPref(Context context, INDIProperty<Element> prop) {
         super(context);
         this.prop = prop;
-
         prop.addINDIPropertyListener(this);
-
         setTitle(createTitle());
         setSummary(createSummary());
     }
@@ -73,17 +71,14 @@ protected Spannable createTitle() {
                 color = IPARCOSApp.getContext().getResources().getColor(R.color.light_red);
                 break;
             }
-
             case BUSY: {
                 color = IPARCOSApp.getContext().getResources().getColor(R.color.light_yellow);
                 break;
             }
-
             case OK: {
                 color = IPARCOSApp.getContext().getResources().getColor(R.color.light_green);
                 break;
             }
-
             default: {
                 color = Color.WHITE;
                 break;