Skip to content

Commit 4c808bc

Browse files
authored
chat idor bug fix (#692)
deliberately dropping the string session_id key to prevent idor hack in chat
1 parent f9d6d6a commit 4c808bc

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

lib/ret_web/channels/hub_channel.ex

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,10 @@ defmodule RetWeb.HubChannel do
301301
broadcast!(
302302
socket,
303303
event,
304-
payload |> Map.put(:session_id, socket.assigns.session_id) |> payload_with_from(socket)
304+
payload
305+
|> Map.delete("session_id")
306+
|> Map.put(:session_id, socket.assigns.session_id)
307+
|> payload_with_from(socket)
305308
)
306309
end
307310

0 commit comments

Comments
 (0)