Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

feat: Async downloads of presets in the Explore tab #727

Open
2 tasks done
Kozova1 opened this issue Feb 25, 2023 · 2 comments
Open
2 tasks done

feat: Async downloads of presets in the Explore tab #727

Kozova1 opened this issue Feb 25, 2023 · 2 comments
Labels
enhancement New feature or request feature-request
Milestone
0.8.0

Comments

@Kozova1
Copy link

Kozova1 commented Feb 25, 2023 •
edited by tfuxu
Loading

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Downloading a preset seems to freeze the entire UI until it finishes downloading.

To Reproduce

  1. Open Gradience
  2. Open the Preset manager
  3. Open the Explore tab
  4. Click "Download" on some of the presets
  5. Try to scroll / hover over a button / etc. and see that the UI is frozen until the download finishes

Expected behavior

I'd expect the UI to not freeze when a theme is being downloaded.

Screenshots

No response

OS

Fedora Linux 37 (Workstation Edition)

DE/WM version

GNOME 43.2

Version

0.4.0

Installation method

Flatpak from Flathub

Enabled system extensions (GNOME specific)

blur-my-shell@aunetx
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Kozova1 Kozova1 added the type/bug Something isn't working label Feb 25, 2023
@github-actions
Copy link
Contributor

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ

@tfuxu tfuxu added this to the 0.8.0 milestone Feb 25, 2023
@tfuxu tfuxu changed the title bug: Downloads of presets in the Explore tab are not async bug: Downloads of presets in the Explore tab are not multi-threaded Feb 25, 2023
@tfuxu
Copy link
Member

tfuxu commented Feb 25, 2023 •
edited
Loading

Known issue. We just didn't yet made functions for fetching and downloading presets asynchronous internally (function for fetching presets is async externally, which isn't perfect, but doesn't cause your issue).
Something to definitely work on for 0.8.0 release. Thanks for the report.

@daudix daudix changed the title bug: Downloads of presets in the Explore tab are not multi-threaded feat: Multi-threaded downloads of presets in the Explore tab Apr 19, 2023
@daudix daudix added enhancement New feature or request feature-request and removed type/bug Something isn't working area/preset-manager labels Apr 19, 2023
@tfuxu tfuxu changed the title feat: Multi-threaded downloads of presets in the Explore tab feat: Async downloads of presets in the Explore tab May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request feature-request
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@Kozova1 @tfuxu @daudix