Skip to content

Commit 502c5a8

Browse files
author
Adrian Salceanu
committed
Parser improvements
1 parent aebb492 commit 502c5a8

File tree

3 files changed

+5
-21
lines changed

3 files changed

+5
-21
lines changed

assets/js/channels.js

-16
Original file line numberDiff line numberDiff line change
@@ -58,22 +58,6 @@ Genie.WebChannels.load_channels = function() {
5858
'payload': payload
5959
}));
6060
}
61-
/*
62-
else {
63-
console.log("WebSocket is not ready");
64-
65-
setTimeout(function() {
66-
if ( Genie.WebChannels.socket.readyState === 3 ) {
67-
try {
68-
Genie.WebChannels.socket = new WebSocket(window.location.protocol.replace("http", "ws") + '//' + window.location.hostname + ':' + Genie.WebChannels.port);
69-
} catch (ex) {
70-
console.log("Failed opening WebSocket connection.");
71-
}
72-
}
73-
sendMessageTo(channel, message, payload)
74-
}, Genie.Settings.webchannels_timeout);
75-
}
76-
*/
7761
}
7862
};
7963

src/renderers/Html.jl

+3-3
Original file line numberDiff line numberDiff line change
@@ -439,10 +439,10 @@ Content-Type: text/html; charset=utf-8
439439
```
440440
"""
441441
function html(data::String; context::Module = @__MODULE__, status::Int = 200, headers::Genie.Renderer.HTTPHeaders = Genie.Renderer.HTTPHeaders(),
442-
layout::Union{String,Nothing,Genie.Renderer.FilePath} = nothing, forceparse::Bool = false, vars...) :: Genie.Renderer.HTTP.Response
442+
layout::Union{String,Nothing,Genie.Renderer.FilePath} = nothing, forceparse::Bool = false, noparse::Bool = false, vars...) :: Genie.Renderer.HTTP.Response
443443
isa(layout, Genie.Renderer.FilePath) && (layout = read(layout, String))
444444

445-
if occursin(raw"$", data) || occursin("<%", data) || layout !== nothing || forceparse
445+
if (occursin(raw"$", data) || occursin("<%", data) || layout !== nothing || forceparse) && ! noparse
446446
Genie.Renderer.WebRenderable(Genie.Renderer.render(MIME"text/html", data; context = context, layout = layout, vars...), status, headers) |> Genie.Renderer.respond
447447
else
448448
Genie.Renderer.WebRenderable(body = data, status = status, headers = headers) |> Genie.Renderer.respond
@@ -648,7 +648,7 @@ function parsehtml(elem::HTMLParser.Node; partial::Bool = true, indent = 0) :: S
648648
elseif length(parts) == 1
649649
attrs_dict[strip(parts[1])] = strip(parts[1])
650650
else
651-
error("Invalid attribute $(string(a))")
651+
string(a)
652652
end
653653
end
654654
end

src/renderers/Js.jl

+2-2
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ end
111111

112112
function js(data::String; context::Module = @__MODULE__, status::Int = 200,
113113
headers::Genie.Renderer.HTTPHeaders = Genie.Renderer.HTTPHeaders("Content-Type" => Genie.Renderer.CONTENT_TYPES[:javascript]),
114-
forceparse::Bool = false, vars...) :: Genie.Renderer.HTTP.Response
115-
if occursin(raw"$", data) || occursin("<%", data) || forceparse
114+
forceparse::Bool = false, noparse::Bool = false, vars...) :: Genie.Renderer.HTTP.Response
115+
if (occursin(raw"$", data) || occursin("<%", data) || forceparse) && ! noparse
116116
Genie.Renderer.WebRenderable(render(MIME"application/javascript", data; context = context, vars...), :javascript, status, headers) |> Genie.Renderer.respond
117117
else
118118
Genie.Renderer.WebRenderable(data, :javascript, status, headers) |> Genie.Renderer.respond

0 commit comments

Comments
 (0)