-
Notifications
You must be signed in to change notification settings - Fork 379
Support plotting OGR GeoJSON files #4599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Wei Ji, the fact is that GMT can already read them (see |
Just following up on this because I'm working on a PR at GenericMappingTools/pygmt#1000. What is required to convert GeoJSON (or any OGR format) data to GMT's internal data structures? I had a read through #3013 again but couldn't really understand what needs to be done. Thought I'd give some test cases too (remove the
|
Wei Ji, #3013 is only marginally related to support reading all the OGR formats. It's something we need if we want to keep information about geometries but we could live without it. The big issue is that the GMT IO is complicated and by GMT's internal data structures I mean having to do programming like this and below. That is, to get the data from GDAL and translate it to fill all of those |
This is a know issue that needs a more general approach. |
Should we reconsider this feature request, considering that GeoJSON is a commonly used format? Ideally we should read the GeoJSON file and convert it to GMT's internal data structure, as mentioned above, but it's technically challenging. Shapefiles are supported by converting shapefiles to OGR_GMT format via |
I agree - but doesnt this apply to all formats not supported by GMT, but supported by ogr2ogr? |
Maybe we should remove support for shapefiles instead.. http://switchfromshapefile.org/. |
We could add more (gpkg for instance) but I'm not particular proud in this GMT solution and a bit reluctant in advertising it for more formats. |
Description of the desired feature
GeoJSON is a standard plaintext OGR format (https://gdal.org/drivers/vector/geojson.html) often used for web mapping and data interchange, and this file format is also rendered by GitHub natively (see https://docs.github.com/en/free-pro-team@latest/github/managing-files-in-a-repository/mapping-geojson-files-on-github), making it an ideal format for sharing online.
There's some action at GenericMappingTools/pygmt#608 on integrating PyGMT with Geopandas, and being able to read GeoJSON directly into GMT
plot
would really help to simplify the coding! Currently GMT can read shapefiles (https://docs.generic-mapping-tools.org/6.1/cookbook/file-formats.html#shapefiles) via GDAL, but it would be nice to extend this to the GeoJSON format (this is a smaller scope than full OGR vector support as in #3013).Are you willing to help implement and maintain this feature? When I pick up C programming 🙂
The text was updated successfully, but these errors were encountered: