Skip to content

Commit ab10797

Browse files
committed
cleanup
1 parent 51b03d7 commit ab10797

11 files changed

+1866
-1956
lines changed

.editorconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ root = true
44
[*]
55
charset = utf-8
66
insert_final_newline = true
7-
indent_style = tab
7+
indent_style = space
88
indent_size = 4
99
tab_width = 4

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ To use this plugin, simply go into its settings and add a new frame, either from
1313
### 🪟 Pane Mode
1414
To open a Custom Frame as a pane, you can use the "Custom Frames: Open" command.
1515

16-
There are also plenty of settings to customize your frame further, including adding custom CSS to the site, adding a ribbon icon, displaying the frame in the center of the editor, and more.
16+
There are also plenty of settings to customize your frame further, including adding custom CSS to the site, adding a ribbon icon, displaying the frame in the center of the editor, and more.
1717

1818
### 🗒️ Markdown Mode
1919
You can also display your custom frames in your Markdown documents. Custom Frames adds a special code block syntax that transforms the code block into a custom frame in Live Preview and Reading mode. Your code block should look like this:
@@ -23,7 +23,7 @@ frame: YOUR FRAME'S NAME
2323
```
2424
~~~
2525

26-
Optionally, you can also pass custom style settings to the embed, which allows you to change things like the embed's height, as well as an additional suffix that will be appended to the frame's regular URL, which can be useful for things like displaying a specific note in Google Keep.
26+
Optionally, you can also pass custom style settings to the embed, which allows you to change things like the embed's height, as well as an additional suffix that will be appended to the frame's regular URL, which can be useful for things like displaying a specific note in Google Keep.
2727

2828
Here's an example using the [Google Keep preset](#-presets):
2929
~~~
@@ -42,7 +42,7 @@ By default, Custom Frames comes with a few presets that allow you to get new pan
4242
- [Obsidian Forum](https://forum.obsidian.md/)
4343
- [Google Keep](https://keep.google.com), optimized for a narrow pane on the side
4444
- [Google Calendar](https://calendar.google.com/calendar/u/0/r/day), optimized by removing some buttons. Close side panel with top-left button.
45-
- [Todoist](https://todoist.com), optimized for a narrow (half-height) side panel by removing some buttons and slimming margins.
45+
- [Todoist](https://todoist.com), optimized for a narrow (half-height) side panel by removing some buttons and slimming margins.
4646
- [Notion](https://www.notion.so/) (it's recommended to close Notion's sidebar if used as a side pane)
4747
- [Twitter](https://twitter.com)
4848

@@ -60,7 +60,7 @@ If you create a frame that you think other people would like, don't hesitate to
6060
## ⚠️ Known Issues
6161
There are a few known issues with Custom Frames. If you encounter any of these, please **don't** report it on the issue tracker.
6262
- In Obsidian **0.14.2 and lower**, a lot of websites don't function properly in custom frames. This is due to these older versions not having features in place that allow for frames to have special, additional functionality related to cookies and headers.
63-
- In Obsidian **0.14.5 and lower**, when dragging or moving a pane, hovering the mouse over a custom frame will cause it to get stuck or behave unexpectedly.
63+
- In Obsidian **0.14.5 and lower**, when dragging or moving a pane, hovering the mouse over a custom frame will cause it to get stuck or behave unexpectedly.
6464

6565
## 🙏 Acknowledgements
6666
Thanks to [lishid](https://github.com/lishid) for their help with making iframes work in Obsidian for a purpose like this. Also thanks to them for *motivating* me to turn Obsidian Keep into a more versatile plugin, which is how Custom Frames was born.

esbuild.config.mjs

+47-47
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import esbuild from "esbuild";
22
import process from "process";
33
import builtins from 'builtin-modules';
4-
import { copy } from 'esbuild-plugin-copy';
4+
import {copy} from 'esbuild-plugin-copy';
55

66
const banner = `/*
77
THIS IS A GENERATED/BUNDLED FILE BY ESBUILD
@@ -11,50 +11,50 @@ if you want to view the source, please visit the github repository of this plugi
1111
const prod = (process.argv[2] === 'production');
1212

1313
esbuild.build({
14-
banner: {
15-
js: banner,
16-
},
17-
entryPoints: ['src/main.ts'],
18-
bundle: true,
19-
external: [
20-
'obsidian',
21-
'electron',
22-
'@codemirror/autocomplete',
23-
'@codemirror/closebrackets',
24-
'@codemirror/collab',
25-
'@codemirror/commands',
26-
'@codemirror/comment',
27-
'@codemirror/fold',
28-
'@codemirror/gutter',
29-
'@codemirror/highlight',
30-
'@codemirror/history',
31-
'@codemirror/language',
32-
'@codemirror/lint',
33-
'@codemirror/matchbrackets',
34-
'@codemirror/panel',
35-
'@codemirror/rangeset',
36-
'@codemirror/rectangular-selection',
37-
'@codemirror/search',
38-
'@codemirror/state',
39-
'@codemirror/stream-parser',
40-
'@codemirror/text',
41-
'@codemirror/tooltip',
42-
'@codemirror/view',
43-
...builtins
44-
],
45-
plugins: [
46-
copy({
47-
assets: [{
48-
from: ["./manifest.json", "./main.js", "./styles.css"],
49-
to: ["./test-vault/.obsidian/plugins/obsidian-custom-frames/."]
50-
}]
51-
}),
52-
],
53-
format: 'cjs',
54-
watch: !prod,
55-
target: 'es2016',
56-
logLevel: "info",
57-
sourcemap: prod ? false : 'inline',
58-
treeShaking: true,
59-
outfile: 'main.js',
14+
banner: {
15+
js: banner,
16+
},
17+
entryPoints: ['src/main.ts'],
18+
bundle: true,
19+
external: [
20+
'obsidian',
21+
'electron',
22+
'@codemirror/autocomplete',
23+
'@codemirror/closebrackets',
24+
'@codemirror/collab',
25+
'@codemirror/commands',
26+
'@codemirror/comment',
27+
'@codemirror/fold',
28+
'@codemirror/gutter',
29+
'@codemirror/highlight',
30+
'@codemirror/history',
31+
'@codemirror/language',
32+
'@codemirror/lint',
33+
'@codemirror/matchbrackets',
34+
'@codemirror/panel',
35+
'@codemirror/rangeset',
36+
'@codemirror/rectangular-selection',
37+
'@codemirror/search',
38+
'@codemirror/state',
39+
'@codemirror/stream-parser',
40+
'@codemirror/text',
41+
'@codemirror/tooltip',
42+
'@codemirror/view',
43+
...builtins
44+
],
45+
plugins: [
46+
copy({
47+
assets: [{
48+
from: ["./manifest.json", "./main.js", "./styles.css"],
49+
to: ["./test-vault/.obsidian/plugins/obsidian-custom-frames/."]
50+
}]
51+
}),
52+
],
53+
format: 'cjs',
54+
watch: !prod,
55+
target: 'es2016',
56+
logLevel: "info",
57+
sourcemap: prod ? false : 'inline',
58+
treeShaking: true,
59+
outfile: 'main.js',
6060
}).catch(() => process.exit(1));

manifest.json

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
2-
"id": "obsidian-custom-frames",
3-
"name": "Custom Frames",
4-
"version": "2.4.6",
5-
"minAppVersion": "1.2.0",
6-
"description": "A plugin that turns web apps into panes using iframes with custom styling. Also comes with presets for Google Keep, Todoist and more.",
7-
"author": "Ellpeck",
8-
"authorUrl": "https://ellpeck.de",
9-
"isDesktopOnly": false
2+
"id": "obsidian-custom-frames",
3+
"name": "Custom Frames",
4+
"version": "2.4.6",
5+
"minAppVersion": "1.2.0",
6+
"description": "A plugin that turns web apps into panes using iframes with custom styling. Also comes with presets for Google Keep, Todoist and more.",
7+
"author": "Ellpeck",
8+
"authorUrl": "https://ellpeck.de",
9+
"isDesktopOnly": false
1010
}

0 commit comments

Comments
 (0)