Skip to content

Duplicated emofs not detected #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cyrilrader opened this issue May 15, 2025 · 0 comments
Open

Duplicated emofs not detected #78

cyrilrader opened this issue May 15, 2025 · 0 comments
Assignees
@cyrilrader

Comments

@cyrilrader
Copy link
Contributor

The tool doesn't detect some duplicated emofs. The check starts at this line: https://github.com/EMODnet/EMODnetBiocheck/blob/572984442a194a0588f4147b678dd78c0ae2f7f6/R/checkdataset.R#L626C1-L626C89

It filters out the emofs that don't have a measurementTypeID from the check. The tool needs to also check for duplicates that don't have a measurementTypeID.

Example of dataset that is affected by this issue: https://ipt.vliz.be/upload/resource?r=ices_datras_bits
@cyrilrader cyrilrader self-assigned this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyrilrader cyrilrader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyrilrader