Skip to content

Commit 73f0e07

Browse files
committed
Fix bug where --max-results could not be set with --no-context-annotations
Previously this command: `twarc2 search --archive --max-results 200 --no-context-annotations banana --limit 100` Would fail with the error: ``` Error: Invalid value for '--max-results': --max-results cannot be greater than 100 when using context annotations. Set --no-context-annotations to remove them, or don't specify them in --tweet-fields. ``` This was occuring because _validate_max_results is called before applying --no-context-annotations, this change just checks no_context_annotations as well.
1 parent e215d89 commit 73f0e07

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

twarc/command2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ def _validate_max_results(context, parameter, value):
423423
)
424424
if value < 10 or value > 500:
425425
raise click.BadParameter("--max-results must be between 10 and 500")
426-
if value > 100 and has_context_annotations:
426+
if value > 100 and (has_context_annotations and not no_context_annotations_set):
427427
raise click.BadParameter(
428428
"--max-results cannot be greater than 100 when using context annotations. Set --no-context-annotations to remove them, or don't specify them in --tweet-fields."
429429
)

0 commit comments

Comments
 (0)