[datadog_security_monitoring_rule] Add default tag support (#2968)

* [datadog_security_monitoring_rule] Add default tag support

* [datadog_security_monitoring_rule] Added tests for default tags

* [datadog_security_monitoring_rule] Addressed documentation comment

* [datadog_security_monitoring_rule] Ran acceptance tests with record

Author: Supam

datadog/fwprovider/framework_provider.go

@@ -222,13 +222,13 @@ func (p *FrameworkProvider) Schema(_ context.Context, _ provider.SchemaRequest,
 				Validators: []validator.List{
 					listvalidator.SizeAtMost(1),
 				},
-				Description: "[Experimental - Monitors and Logs Pipelines only] Configuration block containing settings to apply default resource tags across all resources.",
+				Description: "[Experimental - Logs Pipelines, Monitors and Security Monitoring Rules only] Configuration block containing settings to apply default resource tags across all resources.",
 				NestedObject: schema.NestedBlockObject{
 					Attributes: map[string]schema.Attribute{
 						"tags": schema.MapAttribute{
 							ElementType: types.StringType,
 							Optional:    true,
-							Description: "[Experimental - Monitors and Logs Pipelines only] Resource tags to be applied by default across all resources.",
+							Description: "[Experimental - Logs Pipelines, Monitors and Security Monitoring Rules only] Resource tags to be applied by default across all resources.",
 						},
 					},
 				},

datadog/provider.go

@@ -159,14 +159,14 @@ func Provider() *schema.Provider {
 				Type:        schema.TypeList,
 				Optional:    true,
 				MaxItems:    1,
-				Description: "[Experimental - Monitors and Logs Pipelines only] Configuration block containing settings to apply default resource tags across all resources.",
+				Description: "[Experimental - Logs Pipelines, Monitors and Security Monitoring Rules only] Configuration block containing settings to apply default resource tags across all resources.",
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"tags": {
 							Type:        schema.TypeMap,
 							Optional:    true,
 							Elem:        &schema.Schema{Type: schema.TypeString},
-							Description: "[Experimental - Monitors and Logs Pipelines only] Resource tags to be applied by default across all resources.",
+							Description: "[Experimental - Logs Pipelines, Monitors and Security Monitoring Rules only] Resource tags to be applied by default across all resources.",
 						},
 					},
 				},

datadog/resource_datadog_security_monitoring_rule.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/DataDog/datadog-api-client-go/v2/api/datadogV2"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
@@ -21,7 +22,7 @@ func resourceDatadogSecurityMonitoringRule() *schema.Resource {
 		ReadContext:   resourceDatadogSecurityMonitoringRuleRead,
 		UpdateContext: resourceDatadogSecurityMonitoringRuleUpdate,
 		DeleteContext: resourceDatadogSecurityMonitoringRuleDelete,
-		CustomizeDiff: resourceDatadogSecurityMonitoringRuleCustomizeDiff,
+		CustomizeDiff: customdiff.All(resourceDatadogSecurityMonitoringRuleCustomizeDiff, tagDiff),
 		Importer: &schema.ResourceImporter{
 			StateContext: schema.ImportStatePassthroughContext,
 		},
@@ -444,7 +445,8 @@ func datadogSecurityMonitoringRuleSchema(includeValidate bool) map[string]*schem
 		"tags": {
 			Type:        schema.TypeSet,
 			Optional:    true,
-			Description: "Tags for generated signals.",
+			Computed:    true,
+			Description: "Tags for generated signals. Note: if default tags are present at provider level, they will be added to this resource.",
 			Elem:        &schema.Schema{Type: schema.TypeString},
 		},
 

datadog/tests/cassettes/TestAccDatadogSecurityMonitoringRule_AppsecRule.freeze

@@ -1 +1 @@
-2025-04-07T12:39:37.478358-04:00
+2025-04-29T17:00:32.53202+02:00

datadog/tests/cassettes/TestAccDatadogSecurityMonitoringRule_AppsecRule.yaml

@@ -1 +1 @@
-2025-04-07T14:25:12.472298-04:00
+2025-04-29T17:00:32.539248+02:00

datadog/tests/cassettes/TestAccDatadogSecurityMonitoringRule_Basic.freeze

@@ -1 +1 @@
-2025-03-26T14:59:25.962891-04:00
+2025-04-29T17:00:32.531644+02:00

datadog/tests/cassettes/TestAccDatadogSecurityMonitoringRule_Basic.yaml

@@ -13,7 +13,7 @@ interactions:
         remote_addr: ""
         request_uri: ""
         body: |
-            {"cases":[{"condition":"a \u003e 0","name":"","notifications":[],"status":"high"}],"hasExtendedTitle":true,"isEnabled":true,"message":"validation failed","name":"tf-TestAccDatadogSecurityMonitoringRule_CreateInvalidRule-local-1743015565","options":{"decreaseCriticalityBasedOnEnv":false,"detectionMethod":"threshold","evaluationWindow":1800,"keepAlive":3600,"maxSignalDuration":1800},"queries":[{"aggregation":"count","dataSource":"logs","distinctFields":[],"groupByFields":["@userIdentity.assumed_role"],"metric":"","metrics":[],"name":"","query":"source:source_here"}],"tags":["team:security","env:prod"],"type":"log_detection"}
+            {"cases":[{"condition":"a \u003e 0","name":"","notifications":[],"status":"high"}],"hasExtendedTitle":true,"isEnabled":true,"message":"validation failed","name":"tf-TestAccDatadogSecurityMonitoringRule_CreateInvalidRule-local-1745938832","options":{"decreaseCriticalityBasedOnEnv":false,"detectionMethod":"threshold","evaluationWindow":1800,"keepAlive":3600,"maxSignalDuration":1800},"queries":[{"aggregation":"count","dataSource":"logs","distinctFields":[],"groupByFields":["@userIdentity.assumed_role"],"metric":"","metrics":[],"name":"","query":"source:source_here"}],"tags":["team:security","env:prod"],"type":"log_detection"}
         form: {}
         headers:
             Accept:
@@ -36,4 +36,4 @@ interactions:
                 - application/json
         status: 400 Bad Request
         code: 400
-        duration: 152.514459ms
+        duration: 385.698792ms

datadog/tests/cassettes/TestAccDatadogSecurityMonitoringRule_CreateInvalidRule.freeze

@@ -1 +1 @@
-2025-04-03T15:56:34.113385-04:00
+2025-04-29T17:00:32.537628+02:00