Skip to content

Commit 4a2c463

Browse files
committed
feat(basicSql): remove judge splitListener/collectListener, all sqlParser implements it (#316)
1 parent 5cfad75 commit 4a2c463

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/parser/common/basicSQL.ts

-8
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,6 @@ export abstract class BasicSQL<
239239
return null;
240240
}
241241
const splitListener = this.splitListener;
242-
// TODO: add splitListener to all sqlParser implements and remove following if
243-
if (!splitListener) return null;
244242

245243
this.listen(splitListener, this._parseTree);
246244

@@ -264,8 +262,6 @@ export abstract class BasicSQL<
264262
caretPosition: CaretPosition
265263
): Suggestions | null {
266264
const splitListener = this.splitListener;
267-
// TODO: add splitListener to all sqlParser implements and remove following if
268-
if (!splitListener) return null;
269265

270266
this.parseWithCache(input);
271267
if (!this._parseTree) return null;
@@ -391,10 +387,6 @@ export abstract class BasicSQL<
391387
: void 0;
392388

393389
const collectListener = this.createEntityCollector(input, caretTokenIndex);
394-
// TODO: add entityCollector to all sqlParser implements and remove following if
395-
if (!collectListener) {
396-
return null;
397-
}
398390
// const parser = this.createParserWithCache(input);
399391

400392
// parser.entityCollecting = true;

0 commit comments

Comments
 (0)