fix MemoryPackSerializer.SerializeAsync(Type, Stream, object value) fail

Author: neuecc

src/MemoryPack.Core/MemoryPackSerializer.NonGenerics.cs

@@ -73,7 +73,7 @@ public static async ValueTask SerializeAsync(Type type, Stream stream, object? v
         var tempWriter = ReusableLinkedArrayBufferWriterPool.Rent();
         try
         {
-            Serialize(tempWriter, value, options);
+            SerializeToTempWriter(tempWriter, type, value, options);
             await tempWriter.WriteToAndResetAsync(stream, cancellationToken).ConfigureAwait(false);
         }
         finally
@@ -82,6 +82,20 @@ public static async ValueTask SerializeAsync(Type type, Stream stream, object? v
         }
     }
 
+    static void SerializeToTempWriter(ReusableLinkedArrayBufferWriter bufferWriter, Type type, object? value, MemoryPackSerializerOptions? options)
+    {
+        var state = threadStaticWriterOptionalState;
+        if (state == null)
+        {
+            state = threadStaticWriterOptionalState = new MemoryPackWriterOptionalState();
+        }
+        state.Init(options);
+
+        var writer = new MemoryPackWriter<ReusableLinkedArrayBufferWriter>(ref bufferWriter, state);
+
+        Serialize(type, ref writer, value);
+    }
+
     // Deserialize
 
     public static object? Deserialize(Type type, ReadOnlySpan<byte> buffer, MemoryPackSerializerOptions? options = default)

src/MemoryPack.Unity/Assets/Plugins/MemoryPack/Runtime/MemoryPack.Core/MemoryPackSerializer.NonGenerics.cs

@@ -82,7 +82,7 @@ public static async ValueTask SerializeAsync(Type type, Stream stream, object? v
         var tempWriter = ReusableLinkedArrayBufferWriterPool.Rent();
         try
         {
-            Serialize(tempWriter, value, options);
+            SerializeToTempWriter(tempWriter, type, value, options);
             await tempWriter.WriteToAndResetAsync(stream, cancellationToken).ConfigureAwait(false);
         }
         finally
@@ -91,6 +91,20 @@ public static async ValueTask SerializeAsync(Type type, Stream stream, object? v
         }
     }
 
+    static void SerializeToTempWriter(ReusableLinkedArrayBufferWriter bufferWriter, Type type, object? value, MemoryPackSerializerOptions? options)
+    {
+        var state = threadStaticWriterOptionalState;
+        if (state == null)
+        {
+            state = threadStaticWriterOptionalState = new MemoryPackWriterOptionalState();
+        }
+        state.Init(options);
+
+        var writer = new MemoryPackWriter(ref Unsafe.As<ReusableLinkedArrayBufferWriter, IBufferWriter<byte>>(ref bufferWriter), state);
+
+        Serialize(type, ref writer, value);
+    }
+
     // Deserialize
 
     public static object? Deserialize(Type type, ReadOnlySpan<byte> buffer, MemoryPackSerializerOptions? options = default)

tests/MemoryPack.Tests/NonGenerics.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
@@ -21,6 +22,21 @@ public void StandardBin()
         v2![0].MyProperty.Should().Be(ForeE.C);
         v3![0].MyProperty.Should().Be(ForeE.C);
     }
+
+    // https://github.com/Cysharp/MemoryPack/issues/98
+    [Fact]
+    public async Task StreamCheck()
+    {
+        using var ms = new MemoryStream();
+
+        // Generic version works
+        await MemoryPackSerializer.SerializeAsync(ms, new Item());
+
+        // Non generic version throws MemoryPackSerializationException: System.Object is not registered in this provider.
+        await MemoryPackSerializer.SerializeAsync(typeof(Item), ms, new Item());
+
+     
+    }
 }
 
 [MemoryPackable]
@@ -29,7 +45,11 @@ public partial class MyClass<T>
     public T? MyProperty { get; set; }
 }
 
-
+[MemoryPackable]
+public partial record Item
+{
+    public string Value { get; init; } = Guid.NewGuid().ToString();
+}
 
 public enum ForeE
 {