Skip to content

Add Catch Space to Membership Date Function #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crudemandarin opened this issue Aug 19, 2021 · 2 comments
Open

Add Catch Space to Membership Date Function #78

crudemandarin opened this issue Aug 19, 2021 · 2 comments
Labels
good first issue Good for newcomers Hacktoberfest Keeps track of PR for the hacktoberfest event

Comments

@crudemandarin
Copy link
Contributor

crudemandarin commented Aug 19, 2021

At the moment, if a student attempts to enroll for a semester of CougarCS Membership on the last few days of an academic term, their membership will start and end on that same semester. We should add a catch space, say, 15 days, that if a student tries to enroll within 15 days of the end of the semester, their start term is still that semester, but the end term is extended to the following semester.

Spring Semester End = May 13
Fall Semester End = Dec 16
Catch Space = 15 days

Here are some cases:

Pays for "semester" on January 1, 2000
--> Membership Start = Spring 2000
--> Membership End = Spring 2000

Pays for "year" on March 1, 2000
--> Membership Start = Spring 2000
--> Membership End = Fall 2000

Pays for "semester" on May 5, 2000
--> Membership Start = Spring 2000
--> Membership End = Fall 2000

Student paid within catch space of end of Spring Semester. The end date rolled over to next semester.

Pays for "year" on May 5, 2000
--> Membership Start = Spring 2000
--> Membership End = Spring 2001

Student paid within catch space of end of Spring Semester. The end date rolled over to next semester.

Pays for "semester" on August 1, 2000
--> Membership Start = Fall 2000
--> Membership End = Fall 2000

Pays for "semester" on November 1, 2000
--> Membership Start = Fall 2000
--> Membership End = Fall 2000

Pays for "semester" on Dec 5, 2000
--> Membership Start = Fall 2000
--> Membership End = Spring 2001

Student paid within catch space of end of Fall Semester. The end date rolled over to next semester.

Pays for "year" on Dec 5, 2000
--> Membership Start = Fall 2000
--> Membership End = Fall 2001

Student paid within catch space of end of Fall Semester. The end date rolled over to next semester.

@crudemandarin crudemandarin added the good first issue Good for newcomers label Aug 19, 2021
@crudemandarin
Copy link
Contributor Author

Alternatively: In CougarCS-Client, before we submit to CougarCS-Backend /payment, we could invoke CougarCS-Cloud /contact/status and check if the user is already a member. If the user is a member, we prevent the Stripe purchase and inform the user.

@shubhsheth
Copy link
Member

shubhsheth commented Aug 21, 2021

@crudemandarin That sounds good.

Instead of making 2 calls when they press submit, how about once the UH Id field is updated we perform a check in the background and show that they are already a member and disable the submit button, see image below for example
image

Ofcourse, we'll need to do this check in backend before processing the payment too.

@KevFlo KevFlo added the Hacktoberfest Keeps track of PR for the hacktoberfest event label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest Keeps track of PR for the hacktoberfest event
Projects
None yet
Development

No branches or pull requests

3 participants