-
Notifications
You must be signed in to change notification settings - Fork 88
Task: Add subclasses to FeatureLayer #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Rather than In the services, we may need to just call an appropriate loader rather than a layer. The only concern there is that the FeatureLayer class keeps track of the Coordinate Reference System (CRS). If the GeoDataFrame reliably keeps its CRS that may not be an issue but if I'm not ready to fully implement this yet, but here's what I was thinking:
|
Uh oh!
There was an error while loading. Please reload this page.
Make
FeatureLayer
a baseclassMake
FeatureLayer
a baseclass with subclasses for each source type (EsriFeatureLayer
,CartoFeatureLayer
,GdfFeatureLayer
). Each subclass will implement its ownload_data
method, while shared behavior likeopa_join
will remain onFeatureLayer
which will be an abstract base class (stores shared functionality but isn't initialized directly).Acceptance Criteria
FeatureLayer
) with shared logicload_data
as appropriateself.type
and branching logic inFeatureLayer
Additional context
FeatureLayer.__init__
.FeatureLayer
belongs with which source type.The text was updated successfully, but these errors were encountered: