Allow static libs, fix uninitialized member variable

- Remove SHARED option from add_library to allow static libs,
  CMake then respects the standard BUILD_SHARED_LIBS option.
- Use singleton LoggerImpl to avoid problems with static lib
  startup order.
- Fix uninitialized member variable (found using valgrind).

Author: hefroy

CMakeLists.txt

@@ -126,7 +126,7 @@ link_directories(
 
 file(GLOB CAPI_SRCS "src/CommonAPI/*.cpp")
 list(SORT CAPI_SRCS)
-add_library(CommonAPI SHARED ${CAPI_SRCS})
+add_library(CommonAPI ${CAPI_SRCS})
 target_link_libraries(CommonAPI PRIVATE ${DL_LIBRARY} ${DLT_LIBRARIES})
 set_target_properties(CommonAPI PROPERTIES VERSION ${LIBCOMMONAPI_MAJOR_VERSION}.${LIBCOMMONAPI_MINOR_VERSION}.${LIBCOMMONAPI_PATCH_VERSION} SOVERSION ${LIBCOMMONAPI_MAJOR_VERSION}.${LIBCOMMONAPI_MINOR_VERSION}.${LIBCOMMONAPI_PATCH_VERSION} LINKER_LANGUAGE C)
 set_target_properties (CommonAPI PROPERTIES INTERFACE_LINK_LIBRARY "")

include/CommonAPI/Logger.hpp

@@ -84,7 +84,7 @@ class Logger {
 
 private:
     class LoggerImpl;
-    static std::unique_ptr<LoggerImpl> loggerImpl_;
+    static LoggerImpl &getInstance();
 
     COMMONAPI_EXPORT static bool isLogged(Level _level);
     COMMONAPI_EXPORT static void doLog(Level _level, const std::string& _message);

src/CommonAPI/Logger.cpp

@@ -176,23 +176,26 @@ class Logger::LoggerImpl {
 #endif
 };
 
-std::unique_ptr<Logger::LoggerImpl> Logger::loggerImpl_ =
-        std::unique_ptr<Logger::LoggerImpl>(new Logger::LoggerImpl());
+Logger::LoggerImpl &Logger::getInstance()
+{
+    static LoggerImpl loggerImpl;
+    return loggerImpl;
+}
 
 Logger::Logger() = default;
 Logger::~Logger() = default;
 
 void Logger::init(bool _useConsole, const std::string &_fileName, bool _useDlt,
                   const std::string& _level) {
-    loggerImpl_->init(_useConsole, _fileName, _useDlt, _level);
+    getInstance().init(_useConsole, _fileName, _useDlt, _level);
 }
 
 bool Logger::isLogged(Level _level) {
-    return loggerImpl_->isLogged(_level);
+    return getInstance().isLogged(_level);
 }
 
 void Logger::doLog(Level _level, const std::string& _message) {
-    loggerImpl_->doLog(_level, _message);
+    getInstance().doLog(_level, _message);
 }
 
 } //namespace CommonAPI

src/CommonAPI/Runtime.cpp

@@ -74,6 +74,7 @@ std::shared_ptr<Runtime> Runtime::get() {
 Runtime::Runtime()
     : defaultBinding_(COMMONAPI_DEFAULT_BINDING),
       defaultFolder_(COMMONAPI_DEFAULT_FOLDER),
+      defaultCallTimeout_(0),
       isConfigured_(false),
       isInitialized_(false) {
 }