Fixed issue with unbound events breaking call order

Ticket: jeromeetienne#10
Patch: https://gist.github.com/8e281e63aa2fa0fcdbf8

Author: aron

microevent-test.js

@@ -35,7 +35,7 @@ test('.trigger() calls the handler once for each call', function () {
 
     events.trigger('suprise');
     events.trigger('suprise');
-    assert(handler.callCount === 2, 'Expected handler to be called twice');
+    assert(handler.called === 2, 'Expected handler to be called twice');
 });
 
 test('.trigger() passes additional arguments through to handler', function () {
@@ -48,21 +48,42 @@ test('.trigger() passes additional arguments through to handler', function () {
     assert(handler.args.lastCall[2] === 'three', 'Expected third argument of handler to be three');
 });
 
+test('.trigger() allows handlers to be unbound in handler', function () {
+    var A = createSpy();
+    var B = createSpy(function () { events.unbind('suprise', B); });
+    var C = createSpy();
+
+    events.bind('suprise', A);
+    events.bind('suprise', B);
+    events.bind('suprise', C);
+
+    events.trigger('suprise');
+    assert(A.called === 1, 'Expected A to be called once');
+    assert(B.called === 1, 'Expected B to be called once');
+    assert(C.called === 1, 'Expected C to be called once');
+
+    events.trigger('suprise');
+    assert(A.called === 2, 'Expected A to be called twice');
+    assert(B.called === 1, 'Expected B to be called once');
+    assert(C.called === 2, 'Expected C to be called twice');
+});
+
 // Run the tests.
 if (require.main === module) {
     run(test.suite);
 }
 
 // Test Suite Helpers
 
-function createSpy() {
+function createSpy(fn) {
     return function spy() {
+        fn && fn.apply(this, arguments);
+
         var args = Array.prototype.slice.call(arguments);
         spy.args = (spy.args || []);
         spy.args.push(args);
         spy.args.lastCall = args;
-        spy.called = true;
-        spy.callCount = (spy.callCount || 0) + 1;
+        spy.called = (spy.called || 0) + 1;
     };
 }
 

microevent.js

@@ -25,8 +25,9 @@
         trigger: function(event /* , args... */){
             this._events = this._events || {};
             if (event in this._events === false) { return; }
-            for(var i = 0; i < this._events[event].length; i++){
-                this._events[event][i].apply(this, Array.prototype.slice.call(arguments, 1));
+            var callbacks = (this._events[event] || []).slice();
+            while (callbacks.length) {
+                callbacks.shift().apply(this, Array.prototype.slice.call(arguments, 1));
             }
         }
     };