[porter/aks] portal says template not available

[squillace]

Expected Behavior

Template launches

Actual Behavior

Turns out you have extra chars in the image launching url: https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fazure-cnab-quickstarts%2Faks-28%2Fporter%2Faks%2Fazuredeploy-simple.json

the "aks-28" in the middle needs to be replaced with "master" I believe. I'd do a quick review of other templates if you make this change globally.

Steps to Reproduce the Problem

1. Click on the Simple Deploy button.
   

2. Bug o rama.

[squillace]

@MikeLarah upside is that when the url is corrected, the template deploys properly! Step one!

[MikeEvansLarah]

This URL should be rewritten by the CI workflow that runs after merging a PR to master. However it looks like this workflow failed in this instance https://github.com/Azure/azure-cnab-quickstarts/commit/87fa672527abb1a3db09480747e891de7268f6a5/checks?check_suite_id=356956819

It looks like there is possibly a race condition in the step that commits the changes back to the branch. I'll investigate.

[MikeEvansLarah]

@squillace the other quickstarts should not currently be affected by this

[squillace]

if the run fails, the commit should remain the same and we should not update the readme with anything. We should remain in the previous state, yes?

It looks like the branch being examined is a detached Head pointing to commit '87fa672'. Without a proper branch name GitVersion cannot determine the build version.::error::Unexpected token I in JSON at position 0
##[error]Node run failed with exit code 1

[squillace]

if you merge to master first, I should think you've already gotten the URL correctly calculated..... otherwise, this must always run correctly and not fail. Yes?

[MikeEvansLarah]

Yes we might need to rethink the order in which we run the workflow/merging to master. Currently the URL is updated by the workflow after merging to master, and as we've seen, we can't guarantee the workflow will always succeed (even without bugs, it could fail due to network issues etc).

One option is to always set the URL to have 'master' in, even when building on a branch - however this means that you cannot test the deploy buttons whilst developing.

[MikeEvansLarah]

Closing this issue as this specific case is fixed. I've created #41 to track the more general issue.