JB/Removes optional chaining on yearn bridge (#213)

* Remove optional chaining

* Formatter

* Formatter

Author: jonybur

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aztec/bridge-clients",
-  "version": "0.1.52",
+  "version": "0.1.53",
   "description": "This repo contains the solidity files and typescript helper class for all of the Aztec Connect Bridge Contracts",
   "repository": "[email protected]:AztecProtocol/aztec-connect-bridges.git",
   "license": "Apache-2.0",

src/client/yearn/yearn-bridge-data.ts

@@ -78,20 +78,19 @@ export class YearnBridgeData implements BridgeDataFieldGetters {
       }
     }
 
+    const hasInputAsset = allVaultsForTokens[inputAssetA.erc20Address.toString()] || [];
+    const hasOutputAsset = allVaultsForTokens[outputAssetA.erc20Address.toString()] || [];
+
     // standard deposit
     const matchDepositSituation =
-      (allVaultsForTokens[inputAssetA.erc20Address.toString()] || [])?.findIndex(
-        token => token.toString() === outputAssetA.erc20Address.toString(),
-      ) > -1;
+      hasInputAsset && hasInputAsset.findIndex(token => token.toString() === outputAssetA.erc20Address.toString()) > -1;
     if (matchDepositSituation) {
       return [0];
     }
-
     // standard withdraw
     const matchWithdrawSituation =
-      (allVaultsForTokens[outputAssetA.erc20Address.toString()] || [])?.findIndex(
-        token => token.toString() === inputAssetA.erc20Address.toString(),
-      ) > -1;
+      hasOutputAsset &&
+      hasOutputAsset.findIndex(token => token.toString() === inputAssetA.erc20Address.toString()) > -1;
     if (matchWithdrawSituation) {
       return [1];
     }