Skip to content

Commit 62547f7

Browse files
authored
Merge pull request #136 from AztecProtocol/chore/import-cleanup
Chore/dependency cleanup
2 parents 3b5edf6 + 2b2433c commit 62547f7

File tree

5 files changed

+765
-851
lines changed

5 files changed

+765
-851
lines changed

package.json

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
"solhint:check": "solhint --config ./.solhint.json \"src/**/*.sol\""
2727
},
2828
"dependencies": {
29-
"@aztec/barretenberg": "2.1.0-testnet.29",
30-
"@ethersproject/providers": "^5.6.5"
29+
"@aztec/barretenberg": "2.1.26",
30+
"@ethersproject/providers": "^5.6.8"
3131
},
3232
"jest": {
3333
"transform": {
@@ -42,24 +42,21 @@
4242
"repository": "[email protected]:AztecProtocol/aztec-connect-bridges.git",
4343
"license": "MIT",
4444
"devDependencies": {
45-
"@ethersproject/constants": "^5.5.0",
4645
"@openzeppelin/contracts": "^4.6.0",
4746
"@typechain/ethers-v5": "^9.0.0",
4847
"@typechain/hardhat": "^4.0.0",
49-
"@types/jest": "^27.4.0",
50-
"@types/node-fetch": "^2.6.1",
51-
"ethers": "^5.5.4",
48+
"@types/jest": "^28.1.3",
49+
"ethers": "^5.6.9",
5250
"hardhat": "^2.9.9",
53-
"jest": "^27.5.0",
54-
"node-fetch": "2.6.7",
55-
"prettier": "^2.6.2",
51+
"jest": "^28.1.1",
52+
"prettier": "^2.7.1",
5653
"prettier-plugin-solidity": "^1.0.0-beta.19",
5754
"solhint": "https://github.com/LHerskind/solhint",
5855
"solhint-plugin-prettier": "^0.0.5",
59-
"ts-jest": "^27.1.3",
60-
"ts-node": "^10.4.0",
56+
"ts-jest": "^28.0.5",
57+
"ts-node": "^10.8.1",
6158
"typechain": "^7.0.1",
62-
"typescript": "^4.4.4"
59+
"typescript": "^4.7.4"
6360
},
6461
"files": [
6562
"./client-dest"

src/client/aave/aave-bridge-data.test.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ describe("aave lending bridge data", () => {
8080
const zkAsset = {
8181
id: 3n,
8282
assetType: AztecAssetType.ERC20,
83-
erc20Address: EthAddress.randomAddress().toString(),
83+
erc20Address: EthAddress.random().toString(),
8484
};
8585

8686
aaveLendingBridgeContract = {
@@ -110,7 +110,7 @@ describe("aave lending bridge data", () => {
110110
const zkAsset = {
111111
id: 3n,
112112
assetType: AztecAssetType.ERC20,
113-
erc20Address: EthAddress.randomAddress().toString(),
113+
erc20Address: EthAddress.random().toString(),
114114
};
115115

116116
aaveLendingBridgeContract = {
@@ -136,7 +136,7 @@ describe("aave lending bridge data", () => {
136136
const zkAsset = {
137137
id: 3n,
138138
assetType: AztecAssetType.ERC20,
139-
erc20Address: EthAddress.randomAddress().toString(),
139+
erc20Address: EthAddress.random().toString(),
140140
};
141141

142142
const rate = 3n * 10n ** 25n;
@@ -149,10 +149,10 @@ describe("aave lending bridge data", () => {
149149
currentVariableBorrowRate: 0,
150150
currentStableBorrowRate: 0,
151151
lastUpdateTimestamp: 0,
152-
aTokenAddress: EthAddress.randomAddress().toString(),
153-
stableDebtTokenAddress: EthAddress.randomAddress().toString(),
154-
variableDebtTokenAddress: EthAddress.randomAddress().toString(),
155-
interestRateStrategyAddress: EthAddress.randomAddress().toString(),
152+
aTokenAddress: EthAddress.random().toString(),
153+
stableDebtTokenAddress: EthAddress.random().toString(),
154+
variableDebtTokenAddress: EthAddress.random().toString(),
155+
interestRateStrategyAddress: EthAddress.random().toString(),
156156
id: 0,
157157
};
158158

@@ -178,7 +178,7 @@ describe("aave lending bridge data", () => {
178178
const zkAsset = {
179179
id: 3n,
180180
assetType: AztecAssetType.ERC20,
181-
erc20Address: EthAddress.randomAddress().toString(),
181+
erc20Address: EthAddress.random().toString(),
182182
};
183183

184184
const rate = 3n * 10n ** 25n;
@@ -190,10 +190,10 @@ describe("aave lending bridge data", () => {
190190
currentVariableBorrowRate: 0,
191191
currentStableBorrowRate: 0,
192192
lastUpdateTimestamp: 0,
193-
aTokenAddress: EthAddress.randomAddress().toString(),
194-
stableDebtTokenAddress: EthAddress.randomAddress().toString(),
195-
variableDebtTokenAddress: EthAddress.randomAddress().toString(),
196-
interestRateStrategyAddress: EthAddress.randomAddress().toString(),
193+
aTokenAddress: EthAddress.random().toString(),
194+
stableDebtTokenAddress: EthAddress.random().toString(),
195+
variableDebtTokenAddress: EthAddress.random().toString(),
196+
interestRateStrategyAddress: EthAddress.random().toString(),
197197
id: 0,
198198
};
199199

@@ -218,7 +218,7 @@ describe("aave lending bridge data", () => {
218218
const zkAsset = {
219219
id: 3n,
220220
assetType: AztecAssetType.ERC20,
221-
erc20Address: EthAddress.randomAddress().toString(),
221+
erc20Address: EthAddress.random().toString(),
222222
};
223223

224224
aaveLendingBridgeContract = {

src/client/element/element-bridge-data.test.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {
1111
} from '../../../typechain-types';
1212
import { BridgeId } from '@aztec/barretenberg/bridge_id';
1313
import { AztecAssetType } from '../bridge-data';
14-
import { AddressZero } from '@ethersproject/constants';
1514
import { EthAddress } from '@aztec/barretenberg/address';
1615

1716
jest.mock('../aztec/provider', () => ({
@@ -263,7 +262,7 @@ describe('element bridge data', () => {
263262
},
264263
{
265264
assetType: AztecAssetType.NOT_USED,
266-
erc20Address: AddressZero,
265+
erc20Address: EthAddress.ZERO.toString(),
267266
id: 0n,
268267
},
269268
{
@@ -273,7 +272,7 @@ describe('element bridge data', () => {
273272
},
274273
{
275274
assetType: AztecAssetType.NOT_USED,
276-
erc20Address: AddressZero,
275+
erc20Address: EthAddress.ZERO.toString(),
277276
id: 0n,
278277
},
279278
expiry,
@@ -322,7 +321,7 @@ describe('element bridge data', () => {
322321
},
323322
{
324323
assetType: AztecAssetType.NOT_USED,
325-
erc20Address: AddressZero,
324+
erc20Address: EthAddress.ZERO.toString(),
326325
id: 0n,
327326
},
328327
{
@@ -332,7 +331,7 @@ describe('element bridge data', () => {
332331
},
333332
{
334333
assetType: AztecAssetType.NOT_USED,
335-
erc20Address: AddressZero,
334+
erc20Address: EthAddress.ZERO.toString(),
336335
id: 0n,
337336
},
338337
expiry,

src/client/element/element-bridge-data.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { AddressZero } from '@ethersproject/constants';
21
import { AssetValue, BridgeDataFieldGetters, AuxDataConfig, AztecAsset, SolidityType } from '../bridge-data';
32
import {
43
ElementBridge,
@@ -287,8 +286,8 @@ export class ElementBridgeData implements BridgeDataFieldGetters {
287286
const trancheAddress = pool.trancheAddress;
288287

289288
const funds: FundManagement = {
290-
sender: AddressZero,
291-
recipient: AddressZero,
289+
sender: EthAddress.ZERO.toString(),
290+
recipient: EthAddress.ZERO.toString(),
292291
fromInternalBalance: false,
293292
toInternalBalance: false,
294293
};

0 commit comments

Comments
 (0)