Merge pull request #64 from AztecProtocol/pw/param-rename

Renamed paramter

Author: PhilWindle

package.json

@@ -29,7 +29,7 @@
     "rootDir": "./src"
   },
   "name": "@aztec/bridge-clients",
-  "version": "0.1.36",
+  "version": "0.1.37",
   "description": "This repo contains the solidity files and typescript helper class for all of the Aztec Connect Bridge Contracts",
   "repository": "[email protected]:AztecProtocol/aztec-connect-bridges.git",
   "license": "MIT",

src/client/element/element-bridge-data.test.ts

@@ -1,4 +1,4 @@
-import { ElementBridgeData } from './element-bridge-data';
+import { ChainProperties, ElementBridgeData } from './element-bridge-data';
 import { BigNumber } from 'ethers';
 import { randomBytes } from 'crypto';
 import {
@@ -131,7 +131,7 @@ describe('element bridge data', () => {
     element: ElementBridge = elementBridge as any,
     balancer: IVault = balancerContract as any,
     rollup: RollupProcessor = rollupContract as any,
-    chainProperties: { chunkSize: number } = { chunkSize: 10 },
+    chainProperties: ChainProperties = { eventBatchSize: 10 },
   ) => {
     ElementBridge__factory.connect = () => element as any;
     IVault__factory.connect = () => balancer as any;

src/client/element/element-bridge-data.ts

@@ -34,11 +34,11 @@ export type FundManagement = {
 };
 
 // Some operations on this class require us to scan back over the blockchain
-// to find published events. This is done in batches of blocks. The chunk size in this set of properties
+// to find published events. This is done in batches of blocks. The batch size in this set of properties
 // determines how many blocks to request in each batch.
 // Users of this class can customise this to their provider requirements
 export type ChainProperties = {
-  chunkSize: number;
+  eventBatchSize: number;
 };
 
 interface EventBlock {
@@ -84,7 +84,7 @@ export class ElementBridgeData implements BridgeDataFieldGetters {
     elementBridgeAddress: EthAddress,
     balancerAddress: EthAddress,
     rollupContractAddress: EthAddress,
-    chainProperties: ChainProperties = { chunkSize: 10000 },
+    chainProperties: ChainProperties = { eventBatchSize: 10000 },
   ) {
     const ethersProvider = createWeb3Provider(provider);
     const elementBridgeContract = ElementBridge__factory.connect(elementBridgeAddress.toString(), ethersProvider);
@@ -150,7 +150,7 @@ export class ElementBridgeData implements BridgeDataFieldGetters {
     }
 
     let end = latestBlockNumber;
-    let start = end - (this.chainProperties.chunkSize - 1);
+    let start = end - (this.chainProperties.eventBatchSize - 1);
     start = Math.max(start, earliestBlockNumber);
 
     while (end > earliestBlockNumber) {
@@ -171,7 +171,7 @@ export class ElementBridgeData implements BridgeDataFieldGetters {
 
       // if we didn't find an event then go round again but search further back in time
       end = start - 1;
-      start = end - (this.chainProperties.chunkSize - 1);
+      start = end - (this.chainProperties.eventBatchSize - 1);
       start = Math.max(start, earliestBlockNumber);
     }
   }