Use a unified prefix for internal objects

Author: JanJakes

tests/WP_SQLite_Driver_Tests.php

@@ -1249,17 +1249,17 @@ public function testColumnWithOnUpdate() {
 			array(
 				(object) array(
 					'type'     => 'trigger',
-					'name'     => '___tmp_table_created_at_on_update__',
+					'name'     => '_wp_sqlite__tmp_table_created_at_on_update',
 					'tbl_name' => '_tmp_table',
 					'rootpage' => '0',
-					'sql'      => "CREATE TRIGGER \"___tmp_table_created_at_on_update__\"\n\t\t\tAFTER UPDATE ON \"_tmp_table\"\n\t\t\tFOR EACH ROW\n\t\t\tBEGIN\n\t\t\t  UPDATE \"_tmp_table\" SET \"created_at\" = CURRENT_TIMESTAMP WHERE rowid = NEW.rowid;\n\t\t\tEND",
+					'sql'      => "CREATE TRIGGER \"_wp_sqlite__tmp_table_created_at_on_update\"\n\t\t\tAFTER UPDATE ON \"_tmp_table\"\n\t\t\tFOR EACH ROW\n\t\t\tBEGIN\n\t\t\t  UPDATE \"_tmp_table\" SET \"created_at\" = CURRENT_TIMESTAMP WHERE rowid = NEW.rowid;\n\t\t\tEND",
 				),
 				(object) array(
 					'type'     => 'trigger',
-					'name'     => '___tmp_table_updated_at_on_update__',
+					'name'     => '_wp_sqlite__tmp_table_updated_at_on_update',
 					'tbl_name' => '_tmp_table',
 					'rootpage' => '0',
-					'sql'      => "CREATE TRIGGER \"___tmp_table_updated_at_on_update__\"\n\t\t\tAFTER UPDATE ON \"_tmp_table\"\n\t\t\tFOR EACH ROW\n\t\t\tBEGIN\n\t\t\t  UPDATE \"_tmp_table\" SET \"updated_at\" = CURRENT_TIMESTAMP WHERE rowid = NEW.rowid;\n\t\t\tEND",
+					'sql'      => "CREATE TRIGGER \"_wp_sqlite__tmp_table_updated_at_on_update\"\n\t\t\tAFTER UPDATE ON \"_tmp_table\"\n\t\t\tFOR EACH ROW\n\t\t\tBEGIN\n\t\t\t  UPDATE \"_tmp_table\" SET \"updated_at\" = CURRENT_TIMESTAMP WHERE rowid = NEW.rowid;\n\t\t\tEND",
 				),
 			),
 			$results

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

@@ -21,6 +21,13 @@ class WP_SQLite_Driver {
 	const SQLITE_BUSY   = 5;
 	const SQLITE_LOCKED = 6;
 
+	/**
+	 * An identifier prefix for internal objects.
+	 *
+	 * @TODO: Do not allow accessing objects with this prefix.
+	 */
+	const RESERVED_PREFIX = '_wp_sqlite_';
+
 	/**
 	 * A map of MySQL tokens to SQLite data types.
 	 *
@@ -1244,7 +1251,7 @@ private function execute_alter_table_statement( WP_Parser_Node $node ): void {
 		$this->execute_sqlite_query( 'PRAGMA foreign_keys = OFF' );
 
 		// 2. Create a new table with the new schema.
-		$tmp_table_name        = "_tmp__{$table_name}_" . uniqid();
+		$tmp_table_name        = self::RESERVED_PREFIX . "tmp_{$table_name}_" . uniqid();
 		$quoted_table_name     = $this->quote_sqlite_identifier( $table_name );
 		$quoted_tmp_table_name = $this->quote_sqlite_identifier( $tmp_table_name );
 		$queries               = $this->get_sqlite_create_table_statement( $table_name, $tmp_table_name );
@@ -2277,7 +2284,7 @@ private function get_column_on_update_trigger_query( string $table, string $colu
 		// The trigger wouldn't work for virtual and "WITHOUT ROWID" tables,
 		// but currently that can't happen as we're not creating such tables.
 		// See: https://www.sqlite.org/rowidtable.html
-		$trigger_name = "__{$table}_{$column}_on_update__";
+		$trigger_name = self::RESERVED_PREFIX . "{$table}_{$column}_on_update";
 		return "
 			CREATE TRIGGER \"$trigger_name\"
 			AFTER UPDATE ON \"$table\"