WIP

Author: JanJakes

tests/WP_SQLite_Driver_Tests.php

@@ -285,7 +285,6 @@ public function testShowCreateTable1() {
 			'SHOW CREATE TABLE _tmp_table;'
 		);
 		$results = $this->engine->get_query_results();
-		# TODO: Should we fix mismatch with original `option_value` text NOT NULL,` without default?
 		$this->assertEquals(
 			"CREATE TABLE `_tmp_table` (
   `ID` bigint NOT NULL AUTO_INCREMENT,
@@ -314,7 +313,6 @@ public function testShowCreateTableQuoted() {
 			'SHOW CREATE TABLE `_tmp_table`;'
 		);
 		$results = $this->engine->get_query_results();
-		# TODO: Should we fix mismatch with original `option_value` text NOT NULL,` without default?
 		$this->assertEquals(
 			"CREATE TABLE `_tmp_table` (
   `ID` bigint NOT NULL AUTO_INCREMENT,

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

@@ -905,24 +905,23 @@ private function execute_mysql_query( WP_Parser_Node $ast ) {
 				$this->execute_select_statement( $ast );
 				break;
 			case 'insertStatement':
+				$this->query_type = 'INSERT';
 				$this->execute_insert_statement( $ast );
 				break;
 			case 'updateStatement':
+				$this->query_type = 'UPDATE';
 				$this->execute_update_statement( $ast );
 				break;
 			case 'replaceStatement':
-			case 'deleteStatement':
-				if ( 'insertStatement' === $ast->rule_name ) {
-					$this->query_type = 'INSERT';
-				} elseif ( 'replaceStatement' === $ast->rule_name ) {
-					$this->query_type = 'REPLACE';
-				} elseif ( 'deleteStatement' === $ast->rule_name ) {
-					$this->query_type = 'DELETE';
-				}
-				$query = $this->translate( $ast );
+				$this->query_type = 'REPLACE';
+				$query            = $this->translate( $ast );
 				$this->execute_sqlite_query( $query );
 				$this->set_result_from_affected_rows();
 				break;
+			case 'deleteStatement':
+				$this->query_type = 'DELETE';
+				$this->execute_delete_statement( $ast );
+				break;
 			case 'createStatement':
 				$this->query_type = 'CREATE';
 				$subtree          = $ast->get_child_node();
@@ -1132,6 +1131,81 @@ private function execute_update_statement( WP_Parser_Node $node ): void {
 		$this->set_result_from_affected_rows();
 	}
 
+	private function execute_delete_statement( WP_Parser_Node $node ): void {
+		/*
+		 * Multi-table DELETE.
+		 *
+		 * MySQL supports multi-table DELETE statements that don't work in SQLite.
+		 * These statements can have two flavours:
+		 *  1. "DELETE t1, t2 FROM ... JOIN ... WHERE ..."
+		 *  2. "DELETE FROM t1, t2 USING ... JOIN ... WHERE ..."
+		 *
+		 * We will rewrite such statements into a SELECT to fetch the ROWIDs of
+		 * the rows to delete and the execute a DELETE statement for each table.
+		 */
+		$alias_ref_list = $node->get_child_node( 'tableAliasRefList' );
+		if ( null !== $alias_ref_list ) {
+			$tables = array();
+			foreach ( $alias_ref_list->get_child_nodes() as $table ) {
+				$tables[] = $this->unquote_sqlite_identifier(
+					$this->translate( $table )
+				);
+			}
+
+			$select_list = array();
+			foreach ( $tables as $table ) {
+				$select_list[] = "\"$table\".rowid AS \"{$table}_rowid\"";
+			}
+
+			$alias_map      = array();
+			$table_ref_list = $node->get_child_node( 'tableReferenceList' );
+			foreach ( $table_ref_list->get_descendant_nodes( 'singleTable' ) as $single_table ) {
+				$alias               = $this->unquote_sqlite_identifier(
+					$this->translate( $single_table->get_child_node( 'tableAlias' ) )
+				);
+				$ref                 = $this->unquote_sqlite_identifier(
+					$this->translate( $single_table->get_child_node( 'tableRef' ) )
+				);
+				$alias_map[ $alias ] = $ref;
+			}
+
+			$where_clause = $node->get_child_node( 'whereClause' );
+			if ( null !== $where_clause ) {
+				$where = $this->translate( $where_clause->get_child_node( 'expr' ) );
+			}
+
+			$result = $this->execute_sqlite_query(
+				sprintf(
+					'SELECT %s FROM %s %s',
+					implode( ', ', $select_list ),
+					$this->translate( $table_ref_list ),
+					isset( $where ) ? "WHERE $where" : ''
+				)
+			);
+			$ids    = $result->fetchAll( PDO::FETCH_ASSOC );
+
+			$rows = 0;
+			foreach ( $tables as $table ) {
+				$this->execute_sqlite_query(
+					sprintf(
+						'DELETE FROM "%s" AS %s WHERE rowid IN ( %s )',
+						$alias_map[ $table ],
+						$table,
+						implode( ', ', array_column( $ids, "{$table}_rowid" ) )
+					)
+				);
+				$this->set_result_from_affected_rows();
+				$rows += $this->affected_rows;
+			}
+			$this->set_result_from_affected_rows( $rows );
+			return;
+		}
+
+		$query = $this->translate( $node );
+		$this->execute_sqlite_query( $query );
+		$this->set_result_from_affected_rows();
+	}
+
 	private function execute_create_table_statement( WP_Parser_Node $node ): void {
 		$is_temporary = $node->get_child_node()->has_child_token( WP_MySQL_Lexer::TEMPORARY_SYMBOL );
 		$element_list = $node->get_descendant_node( 'tableElementList' );
@@ -1784,7 +1858,7 @@ private function translate_like( WP_Parser_Node $node ): string {
 		 * We'll probably need to overload the like() function:
 		 *   https://www.sqlite.org/lang_corefunc.html#like
 		 */
-		return $this->translate_sequence( $node->get_children() );
+		return $this->translate_sequence( $node->get_children() ) . " ESCAPE '\\'";
 	}
 
 	private function translate_regexp_functions( WP_Parser_Node $node ): string {