Round coordinates bug

[VegeTato]

Describe the bug

Before the latest update comes
using platformer behavior by Default the [Round coordinates] comes checked and its working fine (before the update)
for example: if playerX = 142(for example) > quit the game
^this worked great before the updates come, when the player reaches 142X the game will quit
But now after the update, the event above^ is not working anymore because (Round coordinates) check is not working anymore, if its checked(by default it is) the game should take the platformer position as a number without commas, but now it Always take the number with Comma if the Round coordinates checked or not
as showing in the example here:

To Reproduce

Steps to reproduce the behavior:

1. Go to events
2. if player at Xpos or Ypos(both not working) = 142(for example)
3. quit game
4. Not gonna quit the game because the number is going to be like 142.51858...etc it will never comes to 142

Example project (its simple):
Bug.zip

Other details

• using windows
• Desktob app, latest version of Gdevelop beta 110

[Silver-Streak]

I went back as far as b89 with the example provided, and it seems to behave the same as b110. That said, I would say "same" is also "incorrect". The round coordinates flag on the platformer character behavior seems to be broken.

So I don't think this has ever worked the way VegeTato expected (or at least not reliably) but I do think it should work as they expected. Round coordinates should actually round the coordinates, and it doesn't seem to be doing so.

b98

b89

Both give the same result, it never detects the character as reaching 315.

Using "Compare Two Numbers" and round(player.X()) = 315 as the condition does work, thoguh.

[Silver-Streak]

Bringing this back up to the crew @4ian and all.

The pixel rounding tag on the platformer behavior definitely is not rounding positions, and this is leading to an increased number of posts on the forums with users looking for solutions.

While long term I'd think exposing the project-wide pixel rounding options (my request here: #2504)

I don't think that replaces the need for this issue to be fixed, and with the increase in posts about it on the forums I thought it important to bring attention back to it.

[ClementPasteau]

Thanks @VegeTato for raising this issue & @Silver-Streak for bumping it up.

I've taken a look at it.
As you mentioned, there are 2 things to distinguish here,

1. the checkbox allowing to round the pixels of an object with platformer behavior
2. an option to enable a pixel-rounding on a project level

For 1. this is currently not working (and probably hasn't been for a while, looking at the code)
I've tried fixing it and weird things happen, especially when the platformer object interacts with a non-platformer object (for instance a platform moving under an object, whilst handling collisions, will not work as expected)
This cannot be fixed easily without a complex solution which in the long-term will be hard to manage in the codebase.

=> As this hasn't been working for a while, my recommendation for this option is to deprecate it, then remove it. If a user want to access rounded pixels, then we recommend using a round() function in the events directly.

For 2. I've tested the global option that PIXI provides: PIXI.settings.ROUND_PIXELS (https://pixijs.download/release/docs/PIXI.settings.html#ROUND_PIXELS)
The results are mixed. In some games, the objects animation looks better, in others, it looks clunky.
I guess this will depend on the type of game you're trying to develop, and will be mainly useful in Pixel-art games.
The PIXI team seems to be working on improving it too, so we know it should get better in the future:

• Fix roundPixels pixijs/pixijs#7495 (not merged yet)
• Round gl.scissor and gl.viewport arguments pixijs/pixijs#7442 (not released yet)

=> We can expose this option as a project-wide one, next to the "Sampling" option.

I'll start working on it, so we can have it in the next release :)

[ClementPasteau]

Just to give an update on this issue:

• the pixel-rounding checkbox on the project level has been added and merged, it will be available in the next release 👍
• removing the checkbox to round coordinates on an object is more complicated than expected - see Fix/round coordinates checkbox #2961