Skip to content

Rearrange the options array #44

Open
@yellow1912

Description

@yellow1912

Right now we are configuring the system like this:

filesystems:
        s3_lib:
            adapter: s3_lib
            visibility: public
            cache: local

Then in the DI Extension we have to check manually:

$options = [];
        if (array_key_exists('visibility', $config)) {
            $options['visibility'] = $config['visibility'];
        }

This will get troublesome later when new options are available etc. I suggest we change it to this:

filesystems:
        s3_lib:
            adapter: s3_lib
            options:
                visibility: public
            cache: local

We can then easily use $config['options'] array in our DI Extension.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions